Date: Fri, 28 Aug 2015 17:44:09 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Allan Jude <allanjude@freebsd.org> Cc: Garrett Cooper <yaneurabeya@gmail.com>, "O'Connor, Daniel" <darius@dons.net.au>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r287236 - head/bin/df Message-ID: <20150828174408.GA74045@FreeBSD.org> In-Reply-To: <55E0859A.50504@freebsd.org> References: <201508280044.t7S0ixfW038766@repo.freebsd.org> <20150828044312.GA88538@FreeBSD.org> <CAGHfRMDw0=-ze4cd7mAoHO_n%2Bt8NdYsR0On2YE5=s_gQ4=xveg@mail.gmail.com> <20150828060458.GA20642@FreeBSD.org> <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au> <CD4128C8-BC71-4FC6-B4FD-9EFBA835AB39@gmail.com> <55E0859A.50504@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 28, 2015 at 12:00:26PM -0400, Allan Jude wrote: > On 2015-08-28 03:48, Garrett Cooper wrote: > >> On Aug 28, 2015, at 00:24, O'Connor, Daniel <darius@dons.net.au> wrote: > >>> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe@freebsd.org> wrote: > >>>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: > >>>> > >>>> Probably because of libxo... > >>> > >>> I'm just wondering how hard is it to write sensible commit logs. :( > >> > >> To put it in a hopefully more helpful way.. > >> Please write why your change is doing something, not what it is doing. > >> > >> Saying what it is doing is OK if it's really hairy, but 99% of the time > >> that isn't the case. > >> > >> Assuming this is a libxo thing the commit log should have been > >> something like.. "Use exit out of main otherwise libxo will not flush > >> properly" (or something similar) > >> > >> Although it would be surprising if libxo required you to use exit().. > > > > Libxo (iirc) doesn't install atexit handlers, which means that you need > > to use exit (or a reason facsimile) in order for it to flush its file > > streams. > > > > This is unintuitive though. I wish it did the right thing as part of > > initializing the streams.. > > This has nothing to do with libxo. libxo has an optional atexit handler, > but as long as you call xo_finish(), then everything is flushed and the > xo handle is closed. xo_finish() is indeed called the line before this > change. Funny how much hypotheses/guesses/speculations it had caused. Which just proves the necessity of good commit logs. But some of us had probably learned a few things about exit(), atexit handlers, flushing the file streams, etc. so thanks for that guys. :) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150828174408.GA74045>