Date: Sun, 08 Jan 2012 10:04:33 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r229416 - head/sys/dev/tws Message-ID: <4F094E11.4010007@FreeBSD.org> In-Reply-To: <201201032017.q03KHZ0Z040723@svn.freebsd.org> References: <201201032017.q03KHZ0Z040723@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 03/01/2012 22:17 Xin LI said the following: > Author: delphij > Date: Tue Jan 3 20:17:35 2012 > New Revision: 229416 > URL: http://svn.freebsd.org/changeset/base/229416 > > Log: > Don't forget to release queue lock when allocation of memory failed. > > Submitted by: Sascha Wildner <saw online de> > Obtained from: DragonFly > MFC after: 2 weeks > > Modified: > head/sys/dev/tws/tws.c > > Modified: head/sys/dev/tws/tws.c > ============================================================================== > --- head/sys/dev/tws/tws.c Tue Jan 3 19:47:32 2012 (r229415) > +++ head/sys/dev/tws/tws.c Tue Jan 3 20:17:35 2012 (r229416) > @@ -685,6 +685,7 @@ tws_init_reqs(struct tws_softc *sc, u_in > { > if (bus_dmamap_create(sc->data_tag, 0, &sc->reqs[i].dma_map)) { > /* log a ENOMEM failure msg here */ > + mtx_unlock(&sc->q_lock); At least here it looks like the new line has inconsistent whitespace indentation. > return(FAILURE); > } > sc->reqs[i].cmd_pkt = &cmd_buf[i]; -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F094E11.4010007>