Date: Tue, 11 Dec 2012 19:58:50 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211155850.GA27873@hades.panopticon> In-Reply-To: <20121211132840.GD58883@ithaqua.etoilebsd.net> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org> <20121211132128.GA50148@hades.panopticon> <20121211132840.GD58883@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
* Baptiste Daroussin (bapt@FreeBSD.org) wrote: > > > Looks like these two should also be mentioned in OPTIONS_DEFINE. > > > > Not adding them to OPTIONS_DEFINE preserves previous behaviour and I > > don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are > > only meaningful to be set globally, and having them in individual ports > > makes large builds much more painful, as a user has to set them for tons > > of ports (even more painful without portmaster or knowing of > > config-recursive). > > My opinion on this is if you have already an OPTIONS_DEFINE it means that the > dialog(1) will be shown anyway so it doesn't hurt to add NLS and DOCS to it. > > if you do not have OPTIONS_DEFINE for something else then yes I can understand > you don't want to bother users with dialog coming up all the time. The said is true, but so it is inconsistent. What if there's single `true' option in addition to DOCS/NLS and it's removed? Removing NLS and DOCS this way has no real reason and is POLA violation wrt users who use them. Leaving them, otoh, is a pain for users which never built this port. I'd prefer some additional infrastructure to deal with it. The following solution seem really convenient for me: Introduce user-set list of options which are handled a bit differently: when the port is build for the first time, and for config-recursive (afaik, both are handled in config-conditional target), the dialog is not brought up if ALL of options are in that list. They are still shown in plain `make config'. That way a user who doesn't care of NLS and DOCS should just set e.g.: OPTIONS_IGNORE= NLS DOCS -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121211155850.GA27873>