Date: Sat, 11 Feb 2012 15:08:24 -0800 From: Doug Barton <dougb@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Gea-Suan Lin <gslin@gslin.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile ports/sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in Message-ID: <4F36F4E8.8040008@FreeBSD.org> In-Reply-To: <201202112237.q1BMbOHK097436@repoman.freebsd.org> References: <201202112237.q1BMbOHK097436@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
These rc.d files are not even complete, never mind meeting the requirements listed in http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html Additionally, in both of them _flags is used for -d and --config where those things should be in command_args instead. In mogstored.in there's also a literal /usr/local. I'll leave it as an exercise for the reader to determine what (rather important) line is missing altogether. Doug On 02/11/2012 14:37, Philip M. Gollucci wrote: > pgollucci 2012-02-11 22:37:24 UTC > > FreeBSD ports repository > > Modified files: > sysutils/p5-MogileFS-Server Makefile > Added files: > sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in > Log: > - Add rc.d files > - Bump PORTREVISION > > PR: ports/164876 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=164876 > Submitted by: Gea-Suan Lin <gslin@gslin.org> > With Hat: perl@ > > Revision Changes Path > 1.23 +2 -0 ports/sysutils/p5-MogileFS-Server/Makefile > 1.1 +19 -0 ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in (new) > 1.1 +19 -0 ports/sysutils/p5-MogileFS-Server/files/mogstored.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/Makefile.diff?&r1=1.22&r2=1.23&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogstored.in > -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F36F4E8.8040008>