Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 16 Nov 2020 10:03:18 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r367716 - in head/sys/dev/mlx5: . mlx5_core
Message-ID:  <202011161003.0AGA3IFp026477@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: hselasky
Date: Mon Nov 16 10:03:18 2020
New Revision: 367716
URL: https://svnweb.freebsd.org/changeset/base/367716

Log:
  Use mlx5core to create/destroy all Dynamically Connected Targets, DCTs.
  
  To prevent a hardware memory leak when a DEVX DCT object is destroyed
  without calling drain DCT before, (e.g. under cleanup flow), need to
  manage its creation and destruction via mlx5 core.
  
  Linux commit:
  c5ae1954c47d3fd8815bd5a592aba18702c93f33
  
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies // NVIDIA Networking

Modified:
  head/sys/dev/mlx5/mlx5_core/mlx5_qp.c
  head/sys/dev/mlx5/qp.h

Modified: head/sys/dev/mlx5/mlx5_core/mlx5_qp.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_core/mlx5_qp.c	Mon Nov 16 10:00:21 2020	(r367715)
+++ head/sys/dev/mlx5/mlx5_core/mlx5_qp.c	Mon Nov 16 10:03:18 2020	(r367716)
@@ -349,19 +349,18 @@ EXPORT_SYMBOL_GPL(mlx5_core_xrcd_dealloc);
 
 int mlx5_core_create_dct(struct mlx5_core_dev *dev,
 			 struct mlx5_core_dct *dct,
-			 u32 *in)
+			 u32 *in, int inlen,
+			 u32 *out, int outlen)
 {
 	struct mlx5_qp_table *table = &dev->priv.qp_table;
-	u32 out[MLX5_ST_SZ_DW(create_dct_out)]	 = {0};
 	u32 dout[MLX5_ST_SZ_DW(destroy_dct_out)] = {0};
 	u32 din[MLX5_ST_SZ_DW(destroy_dct_in)]	 = {0};
-	int inlen = MLX5_ST_SZ_BYTES(create_dct_in);
 	int err;
 
 	init_completion(&dct->drained);
 	MLX5_SET(create_dct_in, in, opcode, MLX5_CMD_OP_CREATE_DCT);
 
-	err = mlx5_cmd_exec(dev, in, inlen, &out, sizeof(out));
+	err = mlx5_cmd_exec(dev, in, inlen, out, outlen);
 	if (err) {
 		mlx5_core_warn(dev, "create DCT failed, ret %d", err);
 		return err;
@@ -387,7 +386,7 @@ int mlx5_core_create_dct(struct mlx5_core_dev *dev,
 err_cmd:
 	MLX5_SET(destroy_dct_in, din, opcode, MLX5_CMD_OP_DESTROY_DCT);
 	MLX5_SET(destroy_dct_in, din, dctn, dct->dctn);
-	mlx5_cmd_exec(dev, &din, sizeof(din), &out, sizeof(dout));
+	mlx5_cmd_exec(dev, &din, sizeof(din), dout, sizeof(dout));
 
 	return err;
 }

Modified: head/sys/dev/mlx5/qp.h
==============================================================================
--- head/sys/dev/mlx5/qp.h	Mon Nov 16 10:00:21 2020	(r367715)
+++ head/sys/dev/mlx5/qp.h	Mon Nov 16 10:03:18 2020	(r367716)
@@ -586,7 +586,8 @@ int mlx5_core_xrcd_alloc(struct mlx5_core_dev *dev, u3
 int mlx5_core_xrcd_dealloc(struct mlx5_core_dev *dev, u32 xrcdn);
 int mlx5_core_create_dct(struct mlx5_core_dev *dev,
 			 struct mlx5_core_dct *dct,
-			 u32 *in);
+			 u32 *in, int inlen,
+			 u32 *out, int outlen);
 int mlx5_core_destroy_dct(struct mlx5_core_dev *dev,
 			  struct mlx5_core_dct *dct);
 int mlx5_core_create_rq_tracked(struct mlx5_core_dev *dev, u32 *in, int inlen,

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011161003.0AGA3IFp026477>