Date: Thu, 20 Apr 2017 15:38:29 +0200 From: peter.blok@bsd4all.org To: Kristof Provost <kristof@sigsegv.be> Cc: Marko Zec <zec@fer.hr>, freebsd-net@freebsd.org Subject: Re: MFC VIMAGE fixes to 11-stable Message-ID: <F1097130-0F5E-4166-B63A-D431E9C60410@bsd4all.org> In-Reply-To: <ACA8734E-88DF-4E7F-BB54-00D393ED7EA6@sigsegv.be> References: <8E6FC1CD-24D5-46D5-A6A1-760DD612F92D@bsd4all.org> <20170420124256.1190665d@x23> <60C3FBF7-7CF3-49AF-9DDF-0589AE9D9146@sigsegv.be> <20170420152853.019e5480@x23> <ACA8734E-88DF-4E7F-BB54-00D393ED7EA6@sigsegv.be>
index | next in thread | previous in thread | raw e-mail
I’ll test this today. > On 20 Apr 2017, at 15:32, Kristof Provost <kristof@sigsegv.be> wrote: > > On 20 Apr 2017, at 15:28, Marko Zec wrote: >> Right. But pfi_attach_group_event() and the other handlers cited above >> _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding the proper >> vnet choice from the caller. >> > Yes, that does look wrong. > I should have looked a bit further. > >> Therefore the proper fix should be as simple as removing CURVNET_SET() / >> CURVNET_RESTORE() macro pairs from the cited handlers. >> > Hopefully, yes. I’ve still got some other pf/vnet issues on my todo list, but > I’ve now added this too. It might actually explain some other bug report I’ve > seen (but not looked at in any depth). > > Regards, > Kristof > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F1097130-0F5E-4166-B63A-D431E9C60410>