Date: Mon, 30 Jan 2023 00:03:54 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: =?utf-8?Q?Stefan_E=C3=9Fer?= <se@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: fdd4c35832de - main - usr.bin/gh-bc: update Makefiles for version 6.2.2 Message-ID: <39329938-5118-440B-B567-77AB64732BD1@FreeBSD.org> In-Reply-To: <202301282250.30SMon4s075057@gitrepo.freebsd.org> References: <202301282250.30SMon4s075057@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 28 Jan 2023, at 23:50, Stefan Eßer <se@FreeBSD.org> wrote: > > The branch main has been updated by se: > > URL: https://cgit.FreeBSD.org/src/commit/?id=fdd4c35832deb1d064f64c2c00e3c8c958be9a51 > > commit fdd4c35832deb1d064f64c2c00e3c8c958be9a51 > Author: Stefan Eßer <se@FreeBSD.org> > AuthorDate: 2023-01-28 22:48:34 +0000 > Commit: Stefan Eßer <se@FreeBSD.org> > CommitDate: 2023-01-28 22:48:34 +0000 > > usr.bin/gh-bc: update Makefiles for version 6.2.2 ... > -CFLAGS+= -DMAINEXEC=${PROGNAME} > -CFLAGS+= -DNLSPATH=/usr/share/nls/%L/%N.cat > -CFLAGS+= -DBUILD_TYPE=A > +CFLAGS=-g -O0 This assignment instead of using "+=" appears to have broken the riscv64sf build for me, since it passes "-march=rv64imac -mabi=lp64" via the global CFLAGS to target the soft-float ABI. That said, is -g -O0 maybe a debugging aid that you left in by accident? Is there any reason not to compile bc with the regular, user-specified CFLAGS? In that case, the line might just be deleted. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY9b7WgAKCRCwXqMKLiCW o28qAJ9Y4hmwgTLfisTjHhq6oyGRw5DRTwCgsa4pgdwPmILTMOa3/BZqErFw2aM= =hGSz -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39329938-5118-440B-B567-77AB64732BD1>