Date: Wed, 19 Jun 2024 07:43:24 +0100 From: Lexi Winter <lexi@le-fay.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 50ecbc5142e1 - main - libipsec: make const-correct Message-ID: <ZnJ-DMLIXW__tk8a@ilythia.eden.le-fay.org> In-Reply-To: <o6s3p503-on24-opr8-1r1q-819r0qsn409q@yvfgf.mnoonqbm.arg> References: <202404230452.43N4qhYd063681@gitrepo.freebsd.org> <o6s3p503-on24-opr8-1r1q-819r0qsn409q@yvfgf.mnoonqbm.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
--bedbMt6zlDZY/qNY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Bjoern A. Zeeb: > > commit 50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a > > Author: Lexi Winter <lexi@le-Fay.ORG> > > AuthorDate: 2024-04-22 21:56:24 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2024-04-23 04:36:34 +0000 > >=20 > > libipsec: make const-correct >=20 > I am surprised that this did not break ipsec-tools and/or other ports > for conflicting types for ipsec_set_policy(), ipsec_get_policylen() and > ipsec_dump_policy(). it did, actually. maybe this should be reverted, although the current situation is also bad since the non-const-correct prototypes cause issues in client code. in the specific case of ipsec-tools i feel like a better fix might be to update ipsec-tools to work with the new prototypes; it does seem to have support for this (using __ipsec_const), that just isn't enabled on FreeBSD and i didn't understand the automake logic enough to determine why. --bedbMt6zlDZY/qNY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEuwt6MaPcv/+Mo+ftDHqbqZ41x5kFAmZyfgwACgkQDHqbqZ41 x5m7rQv+JVEAd3UN+GVdDtgQ3xiBjguu1Hxlbva0SL+vNsqlj0xOpIwRr3UEcrx8 aodY8Vf8dMGsH87Defv+qaqTwCqOTtbNuY6LUoXUgREccHreJTLNiCe2p4Gveloa Gsy6YqPmLHdpsc1g2TbyqgRRmUbUeyXd6N6fEHXLzWMyGQ6T+x+tIvo9qt1Y2nHJ dOZAT0Lzja0htcdg3Q/rrQnHP5+YtLfwARULht65N1C+ttDE1bDI2e1eyV1El3F3 cHUlfrh+tZpJRqOGM1NeNklc83nO6kgPlonW5XwRgyZz0ePkKkI8oso9N0HoM1BI 0ESY6uOqx6HB8ikGRAHWZiX3GNNFpgTALK2YjkTsOO2rOEL/s1hrfM8pwvf+SCml IMxPX+HKSdfQhJ0npapPxg/FHMl8JOhkhhxM+zrdMRihuNVTWNHlxqUKI21VUo3n Z4Kssuz5SBUpApI48heXElIj0fmEJ9zm8YZmxM3xspGMuOn+rqqeThmwiJ88NBG/ wrk29H2e =aNWt -----END PGP SIGNATURE----- --bedbMt6zlDZY/qNY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZnJ-DMLIXW__tk8a>