Date: Fri, 8 Dec 2017 12:11:30 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: cem@freebsd.org Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Eitan Adler <eadler@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee Message-ID: <201712082011.vB8KBUsA068552@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAG6CVpUm5KZYox_yNgg59ZiAM45rKp-69PnpdJTCJt6PdMO8_Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Tue, Dec 5, 2017 at 7:10 PM, Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: eadler > >> Date: Wed Dec 6 02:47:46 2017 > >> New Revision: 326614 > >> URL: https://svnweb.freebsd.org/changeset/base/326614 > >> > >> Log: > >> sponge(1): revert > >> > >> I did a complete buildworld and test... with the program disconnected > >> from the tree. Revert the change for now. > >> > >> (this keeps the change to .arclint which is still correct) > > > > Commited with no log entry that makes any sense about why it was changed, > > please revert .arclint and recommit with a proper log entry for .arclint > > as to why all /tests/ dirs should be ignored. > > I have to agree with Rod. The commit message for the arclint change > is currently "sponge(1): initial commit ?" and doesn't say anything > about the arclint change. Even if the change is correct, the commit > message isn't. Ping, I have not seen this reverted and recommitted with a reasonable explination as to why this change is actually desired. Thanks, -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712082011.vB8KBUsA068552>