Date: Tue, 27 Apr 2021 22:30:48 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 211219] [e1000] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Message-ID: <bug-211219-7501-4jA0vh7Gd3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211219-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-211219-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 --- Comment #38 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Deea55de7b10808b86277d7fdbed2d05d3= c6db1b2 commit eea55de7b10808b86277d7fdbed2d05d3c6db1b2 Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2021-04-25 08:22:23 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-04-27 22:29:39 +0000 e1000: Rework em_msi_link interrupt filter * Fix 82574 Link Status Changes, carrying the OTHER mask bit around as needed. * Move igb-class LSC re-arming out of FAST back into the handler. * Clarify spurious/other interrupt re-arms in FAST. In MSI-X mode, 82574 and igb-class devices use an interrupt filter to handle Link Status Changes. We want to do LSC re-arms in the handler to take advantage of autoclear (EIAC) single shot behavior. 82574 uses 'Other' in ICR and IMS for LSC interrupt types when in MSI-X mode, so we need to set and re-arm the 'Other' bit during attach and after ICR reads in the FAST handler if not an LSC or after handling on LSC due to autoclearing. This work was primarily done to address the referenced PR, but inspired some clarification and improvement for igb-class devices once the intentions of previous bug fix attempts became clearer. PR: 211219 Reported by: Alexey <aserp3@gmail.com> Tested by: kbowling (I210 lagg), markj (I210) Approved by: markj MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D29943 sys/dev/e1000/if_em.c | 40 ++++++++++++++++++++++++---------------- sys/dev/e1000/if_em.h | 2 -- 2 files changed, 24 insertions(+), 18 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211219-7501-4jA0vh7Gd3>