Date: Sun, 27 Jan 2002 15:10:01 -0800 (PST) From: Mike Makonnen <mike_makonnen@yahoo.com> To: freebsd-bugs@FreeBSD.org Subject: Re: i386/34352: USB joystick causes panic on boot Message-ID: <200201272310.g0RNA1P47206@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR i386/34352; it has been noted by GNATS. From: Mike Makonnen <mike_makonnen@yahoo.com> To: Vladimir Tchoukharev <chu@gpi.ru> Cc: FreeBSD-gnats-submit@FreeBSD.ORG, joe@FreeBSD.ORG Subject: Re: i386/34352: USB joystick causes panic on boot Date: Sun, 27 Jan 2002 15:08:06 -0800 On Sun, 27 Jan 2002 23:02:32 +0200 Vladimir Tchoukharev <chu@gpi.ru> wrote: > --------------- > ugen0: Logitec Inc. product 0x207, rev 1.00/1.04 addr 2, iclass 3/0 > uhid0: no report descriptor > device_probe_and_attach: uhid0 attach return 6 > ugen0: Logitec Inc. product 0x207, rev 1.00/1.04 addr 2 > ugen0: setting configuration index 0 failed > device_probe_and_attach: ugen0 attach return 6 > uhci1: <VIA 83C572 USB controller> port 0xd800-0xd81f irq 9 at device > 7.3 on p0 > usb1: <VIA 83C572 USB controller> on uhci1 > usb1: USB revision 1.0 > > Fatal trap 12: page fault while in kernel mode > fault virtual address = 0x64003a > fault code = supervisor read, page not present > instruction pointer = 0x8:0xc0152b0a > stack pointer = 0x10:0xc03aa9a4 > frame pointer = 0x10:0xc03aa9b8 > code segment = base 0x0, limit 0xfffff, type 0x1b > = DPL 0, pres 1, def32 1, gran 1 > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 0 (swapper) > interrupt mask = net tty bio cam > trap number = 12 > panic: page fault > Uptime: 0s > Automatic reboot in 15 seconds - press a key on the console to abort > --------------- This was fixed in -CURRENT in June 2001 (PR 27370), but someone forgot to MFC it.[I've cc'd joe@freebsd.org since he's the current maintainer] Anyways, here's the patch for -STABLE, cheers, mike makonnen Index: sys/dev/usb/uhid.c =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/uhid.c,v retrieving revision 1.27.2.6 diff -u -r1.27.2.6 uhid.c --- sys/dev/usb/uhid.c 5 Oct 2001 07:02:48 -0000 1.27.2.6 +++ sys/dev/usb/uhid.c 27 Jan 2002 22:55:20 -0000 @@ -229,8 +229,6 @@ if (err) { printf("%s: no report descriptor\n", USBDEVNAME(sc->sc_dev)); sc->sc_dying = 1; - if (desc != NULL) - free(desc, M_USBDEV); USB_ATTACH_ERROR_RETURN; } Index: sys/dev/usb/usbdi_util.c =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/usbdi_util.c,v retrieving revision 1.15.2.3 diff -u -r1.15.2.3 usbdi_util.c --- sys/dev/usb/usbdi_util.c 31 Oct 2000 23:23:30 -0000 1.15.2.3 +++ sys/dev/usb/usbdi_util.c 27 Jan 2002 22:54:52 -0000 @@ -460,6 +460,7 @@ *sizep, *descp); if (err) { free(*descp, mem); + *descp = NULL; return (err); } return (USBD_NORMAL_COMPLETION); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201272310.g0RNA1P47206>