Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Sep 2018 08:05:37 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r338550 - stable/11/sys/dev/mlx5/mlx5_en
Message-ID:  <201809100805.w8A85bv8081908@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Mon Sep 10 08:05:36 2018
New Revision: 338550
URL: https://svnweb.freebsd.org/changeset/base/338550

Log:
  MFC r338490:
  Don't stall transmit queue on drops in mlx5en(4).
  
  When a transmitted packet is dropped don't stall the transmit queue.
  
  Sponsored by:		Mellanox Technologies

Modified:
  stable/11/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
==============================================================================
--- stable/11/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c	Mon Sep 10 08:03:52 2018	(r338549)
+++ stable/11/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c	Mon Sep 10 08:05:36 2018	(r338550)
@@ -509,13 +509,11 @@ mlx5e_xmit_locked(struct ifnet *ifp, struct mlx5e_sq *
 	/* Process the queue */
 	while ((next = drbr_peek(ifp, sq->br)) != NULL) {
 		if (mlx5e_sq_xmit(sq, &next) != 0) {
-			if (next == NULL) {
-				drbr_advance(ifp, sq->br);
-			} else {
+			if (next != NULL) {
 				drbr_putback(ifp, sq->br, next);
 				atomic_store_rel_int(&sq->queue_state, MLX5E_SQ_FULL);
+				break;
 			}
-			break;
 		}
 		drbr_advance(ifp, sq->br);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809100805.w8A85bv8081908>