Date: Fri, 3 Apr 2015 15:10:09 -0600 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Failed to build rescue with gcc 4.9 Message-ID: <04452C2A-FB67-465B-AE33-44ED2109672E@bsdimp.com> In-Reply-To: <CAPyFy2DPMRYkH=hYvPCoaoG2e0FEb8CDagQN2_%2BdygRRmtU-ug@mail.gmail.com> References: <CAG=rPVeUQ0mm8JKEWDcdw2trqOrUtDx0pGwm8FqbEzuf9P39rA@mail.gmail.com> <CAG=rPVcfUFme=9BzTHCKtV2bT8ASHX0JPcczp343mjE9=Kfoug@mail.gmail.com> <CAG=rPVeYShPad4KXr1uzczZJ0-_vBytSRArw7wGk_8VZF1vm1A@mail.gmail.com> <2D2191D4-DB6F-4889-9CA9-DFEE495D8302@bsdimp.com> <CAPyFy2DPMRYkH=hYvPCoaoG2e0FEb8CDagQN2_%2BdygRRmtU-ug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Apr 3, 2015, at 2:39 PM, Ed Maste <emaste@freebsd.org> wrote: > > On 3 April 2015 at 13:02, Warner Losh <imp@bsdimp.com> wrote: >> That shows that something in the list is needed. Likely only crunchhide. >> >> It doesn’t tell us why we need it, or when we started needing it, or what >> other conditions we might need it. This information is critical to document >> so we know when we can stop doing it in the future. I’m extremely reluctant >> to commit this until we know these details. > > Yes, it's crunchide. It was broken prior to r277259: > > | crunchide: Correct 64-bit section header offset > | > | For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. > | Instead of using an incorrect hardcoded offset, let the compiler > | figure it out for us with offsetof(). > | > | Differential Revision: https://reviews.freebsd.org/D1543 > > It's not completely clear to me why we did not encounter this before; > a comment before the erroneous write states: > > /* > * update the offset of section header table in elf > * header if needed. > */ > > so I presume something about the object file created by gcc 4.9 causes > this code to be executed, while builds using the in-tree compiler did > not. Ah Yes! I remember now! We should find the FreeBSD version at that date and either build it when we’re cross compiling, or rebuild it when we’re bootstrapping. Thanks for finding this Ed. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVHwGyAAoJEGwc0Sh9sBEAwQ4QALaZUoOfWFW9art2QZ5rDyfz qsI2bgoxrUanYky+17w4D1jLr5EAlagRyHfQcvwd1un1FejzpfsJXmluk7RUzjGv 678BI1jV2GN6jGrfEbAvvABG5B1Wn7qgduYTziIWFfT7DaJuOf1dNhVu3Pc3t7Qn 1Izerokpxqo3B1PQAsl6clrFW8GsBsgClpwgqQ97YhQZivJ/0B5fEA11YQPwqet7 cdKavwpBNMlcFmVwodfnEd+PxX0HZs4dDgPoM+n9uEGonHg9/tYrCYnFevf2x2RT u2FPDNSr7PO2RyFqAw6QwO6JQsHiJ1n6DajwX3v6X1GGCxwUYwDyDkdp+kYA3aG8 hI7ffoC3QWvwsnPKPtdaO3rdxxmkAQaRt72EzjOYbo1WYnqCjLSEEFmmZpjwJuus o3tyfQiBVVM6rFHG+tdJ6QiFqlzrklgnWbQXIbjpK2/CM8IeizBvwNlpZALVy8yi zT9KIt6SvWrZwu7W8KzKu2vdrxyPsUDXeFybhl09ofdAUnCS3UvSBlnzDPjZkKdh JfnC3JIyhx/XJTbTH5ZieBLq9wd+XdFmZhUDYli8ni+Hv7wD3UuHYo4ae+rOqTlu 7R/VVsn2V9Dh2BIqExcA0BvmISPS2QcEWTXcgrK1M69+YNVBtR7B2qkitJUHuDt6 2o6DIfeQ1tiIqQhrnjN/ =lgJJ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?04452C2A-FB67-465B-AE33-44ED2109672E>