Date: Fri, 7 Feb 2014 15:34:27 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r261601 - in head: sys/net sys/netinet sys/netinet6 usr.bin/netstat Message-ID: <D0F6CE00-8648-4C2B-9B4C-22146BFA91E9@FreeBSD.org> In-Reply-To: <201402071518.s17FINtP074186@svn.freebsd.org> References: <201402071518.s17FINtP074186@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 07 Feb 2014, at 15:18 , Gleb Smirnoff <glebius@freebsd.org> wrote: ... > /* > * XXX This does not end up updating timeouts at runtime > * and only reflects the value for the last table added :-/ > */ > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, syn_expire, CTLFLAG_RW, > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, syn_expire, CTLFLAG_RW, > &VNET_NAME(flowtable_syn_expire), 0, > "seconds after which to remove syn allocated flow."); > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, udp_expire, CTLFLAG_RW, > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, udp_expire, CTLFLAG_RW, > &VNET_NAME(flowtable_udp_expire), 0, > "seconds after which to remove flow allocated to UDP."); > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, fin_wait_expire, CTLFLAG_RW, > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, fin_wait_expire, CTLFLAG_RW, > &VNET_NAME(flowtable_fin_wait_expire), 0, > "seconds after which to remove a flow in FIN_WAIT."); > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, tcp_expire, CTLFLAG_RW, > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, tcp_expire, CTLFLAG_RW, > &VNET_NAME(flowtable_tcp_expire), 0, > "seconds after which to remove flow allocated to a TCP connection."); … This is not what we are doing for a lot of other things in the tree which simply treat “inet” as “IP” without version number. Now I know that the floatable sits even between L3 and L2 given it caches pairs, I am still not sure I want to make net.* the “dumping ground” for these. Pending a better solution I don’t care apart from that sysctl.confs entries for the people using floatable after all break with this. — Bjoern A. Zeeb ????????? ??? ??????? ??????: '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.???help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0F6CE00-8648-4C2B-9B4C-22146BFA91E9>