Date: Thu, 3 Apr 2003 21:59:42 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c Message-ID: <20030403185942.GA20191@sunbay.com> In-Reply-To: <20030403155917.GC17860@dragon.nuxi.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> <20030403155917.GC17860@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Apr 03, 2003 at 07:59:17AM -0800, David O'Brien wrote:
> On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > -. if ${WARNS} > 4
> > +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> > CFLAGS += -Wuninitialized
> > . endif
>
> Why not just get rid of it totally? We have this already:
>
> . if ${WARNS} > 1 && ${WARNS} < 5
> # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
> # XXX always get it right.
> CFLAGS += -Wno-uninitialized
> . endif
>
> so we already know it is problematic. OR rather than use:
>
> . if ${WARNS} > 4
> CFLAGS += -Wuninitialized
> . endif
>
> use
>
> . if ${WARNS} == 4
> CFLAGS += -Wuninitialized
> . endif
>
-Wuninitialized may be fixed at some point, but it will still
be unsupported without -O. Why would we remove the support
for it if we can handle it right? I find the -Wuninitialized
very useful, it saved me lot of crashes.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+jISeUkv4P6juNwoRAk9zAJ9gphtIBUy9mOaa20ZmqhYZW+JJVQCeMnVl
ceS5EvWOKcf4X9pED51zfkE=
=8ydh
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030403185942.GA20191>