Date: Mon, 24 Feb 2014 15:41:16 +0100 From: Antoine Brodin <antoine@FreeBSD.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, apache@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org> Subject: Re: Patch for devel/apr1 Message-ID: <CAALwa8k4785Je3y8JjUzswZ0Z60k6Lu=VJ_XGRfmOAryimSaKQ@mail.gmail.com> In-Reply-To: <si3TtFF7heojydymL3/cz%2BBr880@W4hAcbyY3boCl2ecg4/u9JA8hSY> References: <W/LXQdmArDuvEZINc6uIco1Q77Q@DMnR65URhR2fwN60Ud5mwsygncU> <rPjS0dCkOXQwLs9s6PofV/p/GT4@Edl7HbwHujl6CRBF88MhHM/peE4> <d73YgQvFILY2/L/3172O%2BSqT8sQ@Edl7HbwHujl6CRBF88MhHM/peE4> <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> <si3TtFF7heojydymL3/cz%2BBr880@W4hAcbyY3boCl2ecg4/u9JA8hSY>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 24, 2014 at 3:30 PM, Eygene Ryabinkin <rea@freebsd.org> wrote: > Mathieu, good day. > > Mon, Feb 24, 2014 at 02:40:34PM +0100, Mathieu Arnold wrote: >> +--On 24 f=E9vrier 2014 04:31:40 +0400 Eygene Ryabinkin <rea@freebsd.org= > >> wrote: >> | Sat, Feb 22, 2014 at 12:04:51PM +0400, Eygene Ryabinkin wrote: >> |> Thu, Feb 20, 2014 at 11:16:40PM +0400, Eygene Ryabinkin wrote: >> |> > Attached is the patch that fixes handling of WITH_/WITHOUT_ knobs >> |> > (and may be something else). How to reproduce: set WITH_LDAP via >> |> > make's command line and build apr1. You will end up with APR that >> |> > doesn't support LDAP. Tested on port's HEAD@r343654. >> |> >> |> Gentlemen? Is anyone around to look at this? >> | >> | Involving portmgr. Gentlemen, devel/apr1 doesn't have OPTIONS_DEFINE = set, >> | so this breaks at least handling of WITH/WITHOUT options. Can I have >> | approval for the patch? >> >> Hum, no, I don't see why it would be needed. What does it fix ? > > Building with 'make WITH_LDAP=3Dyes', for example. It won't produce > your LDAP-powered APR if you hadn't used 'make options' and selected > LDAP there before. > > Do you familiar with > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.= html > section 5.12.2.2? Or, alternatively, with Mk/bsd.options.mk lines 178, > {{{ > ALL_OPTIONS:=3D ${OPTIONS_DEFINE:O:u} > }}} > and block starting at line 260 > {{{ > .for opt in ${ALL_OPTIONS} > .if defined(WITH_${opt}) > PORT_OPTIONS+=3D ${opt} > .endif > .if defined(WITHOUT_${opt}) > PORT_OPTIONS:=3D ${PORT_OPTIONS:N${opt}} > .endif > .endfor > }}} Hi, WITH_LDAP syntax is deprecated and doesn't work for options in a group. You can use make WITH=3DLDAP Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8k4785Je3y8JjUzswZ0Z60k6Lu=VJ_XGRfmOAryimSaKQ>