Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Jun 2010 11:28:46 +0000 (UTC)
From:      Martin Matuska <mm@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r209101 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <201006121128.o5CBSkjJ085397@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mm
Date: Sat Jun 12 11:28:46 2010
New Revision: 209101
URL: http://svn.freebsd.org/changeset/base/209101

Log:
  Fix arc_read_done may try to byteswap undefined data (sparc related)
  
  OpenSolaris onnv-revision:	10839:cf83b553a2ab
  
  Obtained from:	OpenSolaris (Bug ID 6836714)
  Approved by:	pjd, delphij (mentor)
  MFC after:	3 days

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c	Sat Jun 12 11:27:10 2010	(r209100)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c	Sat Jun 12 11:28:46 2010	(r209101)
@@ -2687,7 +2687,7 @@ arc_read_done(zio_t *zio)
 	/* byteswap if necessary */
 	callback_list = hdr->b_acb;
 	ASSERT(callback_list != NULL);
-	if (BP_SHOULD_BYTESWAP(zio->io_bp)) {
+	if (BP_SHOULD_BYTESWAP(zio->io_bp) && zio->io_error == 0) {
 		arc_byteswap_func_t *func = BP_GET_LEVEL(zio->io_bp) > 0 ?
 		    byteswap_uint64_array :
 		    dmu_ot[BP_GET_TYPE(zio->io_bp)].ot_byteswap;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006121128.o5CBSkjJ085397>