Date: Thu, 28 Nov 2013 15:38:20 +0200 From: Aleksandr Rybalko <ray@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: Aleksandr Rybalko <ray@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r257451 - in user/ed/newcons/sys/dev/drm2: . i915 radeon Message-ID: <20131128153820.f611e65cb7214f478a9ebfe5@freebsd.org> In-Reply-To: <529741CE.7040805@FreeBSD.org> References: <201310311439.r9VEd5fh025537@svn.freebsd.org> <529741CE.7040805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 28 Nov 2013 15:14:54 +0200 Andriy Gapon <avg@FreeBSD.org> wrote: > on 31/10/2013 16:39 Aleksandr Rybalko said the following: > > Author: ray > > Date: Thu Oct 31 14:39:04 2013 > > New Revision: 257451 > > URL: http://svnweb.freebsd.org/changeset/base/257451 > > > > Log: > > Change drm2 to attach fbd as device. > > Radeon driver not ready yet. > > > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > user/ed/newcons/sys/dev/drm2/drm_fb_helper.c > > user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > > user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > > > > > Modified: user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > > ============================================================================== > > --- user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:11:14 2013 (r257450) > > +++ user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:39:04 2013 (r257451) > > > @@ -400,6 +421,10 @@ static device_method_t i915_methods[] = > > DEVMETHOD(device_suspend, i915_suspend), > > DEVMETHOD(device_resume, i915_resume), > > DEVMETHOD(device_detach, drm_detach), > > + > > + /* Framebuffer service methods */ > > + DEVMETHOD(fb_getinfo, i915_fb_helper_getinfo), > > + > > DEVMETHOD_END > > }; > > > > > > Modified: user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > > ============================================================================== > > --- user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:11:14 2013 (r257450) > > +++ user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:39:04 2013 (r257451) > > > @@ -495,6 +518,10 @@ static device_method_t radeon_methods[] > > DEVMETHOD(device_suspend, radeon_suspend), > > DEVMETHOD(device_resume, radeon_resume), > > DEVMETHOD(device_detach, drm_detach), > > + > > + /* Framebuffer service methods */ > > + DEVMETHOD(fb_getinfo, radeon_fb_helper_getinfo), > > + > > DEVMETHOD_END > > }; > > > It seems that this change these modules can not be loaded when a kernel is > compiled with syscons rather than vt (newcons). > The problem is that fb_getinfo_desc is undefined in that case. It is supposed > to come from fb_if.m -> fb_if.c -> fb_if.o. > > Is this intentional? Yeah, currently fbd is not standalone module, it is depended on VT(9) (a.k.a. newcons) presence. From another point, syscons can't use (at least now) DRM's fb_helper. If syscons present, newcons will not be able to attach, since he will need to replace handler of /dev/ttyvX files, which is impossible as I know (at least now). > > -- > Andriy Gapon -- Aleksandr Rybalko <ray@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131128153820.f611e65cb7214f478a9ebfe5>