Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Oct 2012 17:39:01 +0200
From:      Andreas Tobler <andreast@FreeBSD.org>
To:        Ed Schouten <ed@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r241777 - in head: bin/dd libexec/rpc.rusersd libexec/talkd usr.bin/cksum usr.bin/m4 usr.sbin/mtree usr.sbin/newsyslog usr.sbin/services_mkdb
Message-ID:  <5082C595.3040504@FreeBSD.org>
In-Reply-To: <201210201033.q9KAXGRm007583@svn.freebsd.org>
References:  <201210201033.q9KAXGRm007583@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 20.10.12 12:33, Ed Schouten wrote:
> Author: ed
> Date: Sat Oct 20 10:33:15 2012
> New Revision: 241777
> URL: http://svn.freebsd.org/changeset/base/241777
>
> Log:
>    More -Wmissing-variable-declarations fixes.
>
>    In addition to adding missing `static' keywords:
>    - bin/dd: Pull in `extern.h' to guarantee consistency with source file.
>    - libexec/rpc.rusersd: Move shared globals into an extern.h.
>    - libexec/talkd: Move `debug' and `hostname' into extern.h.
>    - usr.bin/cksum: Put counters in extern.h, as they are used by ckdist/mtree.
>    - usr.bin/m4: Move `end_result' into extern.h.
>    - usr.sbin/services_mkdb: Move shared globals into an extern.h.

Hi Ed,

I get the same failures (on amd64/powerpc64) as the TB on mips for example:

/src/usr.bin/m4/parser.y:26:18: error: mdef.h: No such file or directory
/src/usr.bin/m4/parser.y:27:20: error: extern.h: No such file or directory

Is this the right fix?

TIA,
Andreas

Index: Makefile
===================================================================
--- Makefile	(revision 241783)
+++ Makefile	(working copy)
@@ -5,7 +5,7 @@
  # 	if you want the paste & spaste macros.

  PROG=	m4
-CFLAGS+=-DEXTENDED -I${.CURDIR}/lib
+CFLAGS+=-DEXTENDED -I${.CURDIR} -I${.CURDIR}/lib
  LDADD=	-ly -ll -lm
  # clang needs 1 while with gcc we can use 2
  #WARNS=	1




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5082C595.3040504>