Date: Tue, 25 Nov 2014 15:14:56 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ermal =?utf-8?Q?Lu=C3=A7i?= <eri@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274709 - head/sys/netpfil/pf Message-ID: <861torxt7j.fsf@nine.des.no> In-Reply-To: <CAPBZQG3i2h-wUQa16d0gt%2BfpsfNEBHgZsvtryvnwtrPVZsw8YA@mail.gmail.com> ("Ermal =?utf-8?Q?Lu=C3=A7i=22's?= message of "Tue, 25 Nov 2014 14:33:30 %2B0100") References: <201411191331.sAJDV9bH092190@svn.freebsd.org> <86tx1nvcy4.fsf@nine.des.no> <86ppcbvb04.fsf@nine.des.no> <86ioi3y0gb.fsf@nine.des.no> <CAPBZQG3i2h-wUQa16d0gt%2BfpsfNEBHgZsvtryvnwtrPVZsw8YA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ermal Lu=C3=A7i <eri@freebsd.org> writes: > Also this only affects the traffic sourced by the host itself and not > forwarded traffic and I think this patch will provide a regression for > the issues that the committed patch does. How? The code as it stands (after your commit) is incorrect and will trigger an assertion in vtnet(4). You could argue that it is less incorrect than the original, but the cure is worse than the disease. My patch fixes the panic as well as two preexisting bugs (not taking the IP checksum into account in the IPv4 path, and ignoring hardware offloading). See https://bugs.freebsd.org/192013#c10 for an explanation of what it does and why. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861torxt7j.fsf>