Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Sep 2001 21:25:27 -0500
From:      Alfred Perlstein <bright@mu.org>
To:        "Andrey A. Chernov" <ache@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/stdio stdio.c
Message-ID:  <20010906212527.W81307@elvis.mu.org>
In-Reply-To: <200109070213.f872DCa19917@freefall.freebsd.org>; from ache@FreeBSD.org on Thu, Sep 06, 2001 at 07:13:11PM -0700
References:  <200109070213.f872DCa19917@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Andrey A. Chernov <ache@FreeBSD.org> [010906 21:13] wrote:
> ache        2001/09/06 19:13:11 PDT
> 
>   Modified files:
>     lib/libc/stdio       stdio.c 
>   Log:
>   For now just back out seek error checking in __SAPP case, it cause problems
>   with non-seekable streams.  Now here is what here was originally, but it is
>   ugly, producing unneded seek syscall on each non-seekable stream write.  I'll
>   think about proper solution later.

Both revisions did basically the same thing, except that the previous
change you did broke things.  One way to fix this would be to record
the failed lseek returning EISPIPE and noting that the backing
object is not seekable, from then on you could avoid the unnescesary
syscalls.

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010906212527.W81307>