Date: Thu, 27 Jul 2006 22:06:21 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Hajimu UMEMOTO <ume@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/route Makefile src/sbin/rtsol Makefile src/sbin/setkey Makefile Message-ID: <20060727180621.GB5075@comp.chem.msu.su> In-Reply-To: <ygeejw7w0ig.wl%ume@mahoroba.org> References: <200607271326.k6RDQTBt081170@repoman.freebsd.org> <ygeejw7w0ig.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 28, 2006 at 12:06:15AM +0900, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Thu, 27 Jul 2006 13:26:29 +0000 (UTC) > >>>>> Yar Tikhiy <yar@FreeBSD.org> said: > > yar> yar 2006-07-27 13:26:29 UTC > > yar> FreeBSD src repository > > yar> Modified files: > yar> sbin/route Makefile > yar> sbin/rtsol Makefile > yar> sbin/setkey Makefile > yar> Log: > yar> Obey MK_INET6_SUPPORT. > yar> This is also a good chance to apply style.Makefile(5) in some cases. > > rtsol is a utility only for IPv6, and INET6 is not referred from rtsol > sources. Since INET6 might be reffered from include files, -DINET6 is > required, here. So, building rtsol without -DINET6 is not good. You > may want to exclude rtsol from building by src/sbin/Makefile, instead. Thank you, I obviously missed that. I've just found that rtsol doesn't depend on INET6 at all (the binary stays the same,) so I've fixed Makefiles for sbin/rtsol and sbin accordingly. P.S. I don't think that any conventional include files should depend on INET6 either. Some of our /usr/include files refer to INET6, but they do from their kernel-specific parts only. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060727180621.GB5075>