Date: Sat, 15 Apr 2017 12:17:16 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: John Baldwin <jhb@freebsd.org> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, src-committers <src-committers@freebsd.org>, rgrimes@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <201704151917.v3FJHGSf013257@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <1774031.vuxxQt1GW8@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Friday, April 14, 2017 07:40:57 PM Ngie Cooper wrote: > > > > > On Apr 14, 2017, at 18:49, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > > Do we use KiB, MiB, GiB,... any place else in the system? I cant think of > > > a place we do this, so please, lets not start doing this here? > > The du manpage does at least. Should that be reverted? My 5.4p8 man pages does not have any IEC units in it. Doesnt du -h print stuff in none IEC units, so this is kinda a man page vs actual code error. Oh wait, it is more errorful than that, using -h leaves off units and only prints scale of K/M/G/... and not KB/MB/GB :-(. > > humanize_number(3) from libutil uses IEC units. > > Note that it is optional though. You can use flags to decide what you want > and the default is to not use IEC. ls -h uses humanize_number but not with > IEC units. In particular, there are flags to control the scaling and > prefixes used: HN_DIVISOR_1000 and HN_IEC_PREFIXES. The default is to use > power-of-2 scaling with non-IEC prefixes (so KB == 1024 by default). > Currently nothing in base uses HN_IEC_PREFIXES. > > (I see you already reverted the printf, just wanted to point out that the > humanize_number behavior is configurable.) Yes, and it would be nice to round out this functional set fixing its lack of uint64_t support, fixing all the things Bruce pointed out and then to start using it. Oh, and probably add an environment control to get either IEC or non IEC and scale either 1024 or 1000. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704151917.v3FJHGSf013257>