Date: Wed, 22 Oct 2014 11:48:30 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r273417 - head Message-ID: <86iojco2oh.fsf@nine.des.no> In-Reply-To: <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> (Warner Losh's message of "Tue, 21 Oct 2014 19:49:33 -0600") References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@bsdimp.com> writes:
> I=E2=80=99ll fix this. I think we need to have a MK_TESTS_SUPPORT that bu=
ilds
> the libatf stuff when yes, and omits it when no, since we don=E2=80=99t w=
ant
> the tests building when we=E2=80=99re building the 4.3 stage.
I agree, bundling everything under MK_TESTS does not make much sense.
Automake has the same bug ("make check" will both build the tests and
run them, and while you can rerun the tests without rebuilding them
("make recheck"), there is no way to build them without running them.
I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though. The
test framework is probably useful on its own.
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86iojco2oh.fsf>