Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Nov 2009 00:43:10 +0100 (CET)
From:      Alexander Best <alexbestms@wwu.de>
To:        <freebsd-current@FreeBSD.org>
Subject:   [patch] ee segfaults when jumping to line zero
Message-ID:  <permail-20091109234310f0889e8400004f7f-a_best01@message-id.uni-muenster.de>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
hi there,

could somebody please commit the attached patch to HEAD and mfc it asap? it's
a no brainer. ee inits a *char with NULL and accesses it before the *char is
being initialised properly.

to repeat:

1)start `ee'
2)press `ctrl+c'
3)enter `0' =====>>> BAM!!!

this will occur under all branches running ee 1.5.0. the problem might also
occur in branches with previous versions of ee. i think only 6-stable is still
using the 1.4.X ee release.

the patch was submitted by Fredrik Lindberg in bin/137707, but sadly nobody
paid attention to it. :(

this fix should also be forwarded to re@ asap so we can have it in
8.0-RELEASE.

alex

[-- Attachment #2 --]
Index: ee.c
===================================================================
--- ee.c	(revision 196171)
+++ ee.c	(working copy)
@@ -1993,7 +1993,7 @@
 	int number;
 	int i;
 	char *ptr;
-	char *direction = NULL;
+	char *direction = "d"; 
 	struct text *t_line;
 
 	ptr = cmd_str;

--------------060704070207090201020407--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-20091109234310f0889e8400004f7f-a_best01>