Date: Thu, 24 Jan 2019 17:44:15 -0800 From: Devin Teske <dteske@FreeBSD.org> To: rgrimes@freebsd.org Cc: Devin Teske <dteske@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, Edward Tomasz Napierala <trasz@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343416 - head/bin/sh Message-ID: <0D1FAD4B-5E35-4CCE-AA30-E94E3534F890@FreeBSD.org> In-Reply-To: <201901250023.x0P0NrC0085675@pdx.rh.CN85.dnsmgr.net> References: <201901250023.x0P0NrC0085675@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 24, 2019, at 4:23 PM, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> On Thu, 2019-01-24 at 15:55 -0800, Rodney W. Grimes wrote: >>>> Author: trasz >>>> Date: Thu Jan 24 23:34:51 2019 >>>> New Revision: 343416 >>>> URL: https://svnweb.freebsd.org/changeset/base/343416 >>>>=20 >>>> Log: >>>> Install .shrc for root, and set PS1 for the toor account. >>>=20 >>> And a dozen other aliases :-( >>> Please do not contaiminate the prestine environment with >>> personal preferences. In the start of the project we >>> did a great deal of work to remove and eliminate these >>> types of things, only the few csh aliases where retained. >>>=20 >>> This is really the domain of a systems administrator to >>> decide and making work for them to clean this out is >>> not going to make them happy. >>>=20 >>> The commands in an ENV file well be executed by >>> every single shell that is started, not just an >>> interactive shell, unless I am mis reading the >>> man page: >>> If the environment variable ENV is set on >>> entry to a shell, or is set in the .profile of a login shell, the >>> shell >>> then subjects its value to parameter expansion and arithmetic >>> expansion >>> and reads commands from the named file. >=20 > The man page needs fixed here too, it does infact later state > that THIS version of sh does not always run ENV, only for > interactive shells. Which is a good thing, but there is > still this un needed contaimination with aliases. >=20 > You also just caused me to have to revive my .profile diff > cause the addition of the ENV falls in the context range > of my local mods. I am sure this effects others. Please > do consider that these files have been very very rarely > touched over decades of time. >=20 +1 Will be watching for the revert of this. --=20 Devin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0D1FAD4B-5E35-4CCE-AA30-E94E3534F890>