Date: Sun, 23 Dec 2007 22:56:01 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 131496 for review Message-ID: <200712232256.lBNMu14f073852@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=131496 Change 131496 by rwatson@rwatson_cinnamon on 2007/12/23 22:55:03 Un-XXX one comment that is now the status quot, and remove another that observes what is now arguably a non-problem. Affected files ... .. //depot/projects/zcopybpf/src/sys/net/bpf.c#31 edit Differences ... ==== //depot/projects/zcopybpf/src/sys/net/bpf.c#31 (text+ko) ==== @@ -616,9 +616,9 @@ dev->si_drv1 = d; /* - * XXXRW: For historical reasons, perform a one-time initialization - * call to the buffer routines, even though we're not yet committed - * to a particular buffer method. + * For historical reasons, perform a one-time initialization call to + * the buffer routines, even though we're not yet committed to a + * particular buffer method. */ bpf_buffer_init(d); d->bd_bufmode = BPF_BUFMODE_DEFAULT; @@ -688,11 +688,6 @@ BPFD_LOCK(d); d->bd_pid = curthread->td_proc->p_pid; if (d->bd_bufmode != BPF_BUFMODE_BUFFER) { - /* - * XXXRW: For now, we don't implement a uiomove for the - * scatter-gather buffers associated with BPF_BUFMODE_ZBUF, - * so simply disallow read(). - */ BPFD_UNLOCK(d); return (EOPNOTSUPP); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712232256.lBNMu14f073852>