Skip site navigation (1)Skip section navigation (2)
Date:      Mon,  5 Jun 1995 02:25:12 +0400 (MSD)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA=?= =?KOI8-R?Q?=FE=C5=D2=CE=CF=D7=?= aka "Andrey A. Chernov, Black Mage" <ache@astral.msk.su>
To:        davidg@freefall.cdrom.com, freebsd-bugs@freefall.cdrom.com, pb@fasterix.freenix.fr
Cc:        Bruce Evans <bde@zeta.org.au>
Subject:   Re: Changed information for PR kern/445
Message-ID:  <pj8BZqlSYQ@astral.msk.su>
In-Reply-To: <199506041629.JAA15484@freefall.cdrom.com>; from David Greenman at Sun, 4 Jun 1995 09:29:34 -0700
References:  <199506041629.JAA15484@freefall.cdrom.com>

index | next in thread | previous in thread | raw e-mail

-----BEGIN PGP SIGNED MESSAGE-----

In message <199506041629.JAA15484@freefall.cdrom.com> David Greenman
    writes:

>Synopsis: write() returns EAGAIN during uucico 'i' transfers

>State-Changed-From-To: open-closed
>State-Changed-By: davidg
>State-Changed-When: Sun Jun 4 09:28:49 PDT 1995
>State-Changed-Why:
>The bug was introduced by an incorrect change in rev 1.44. It's been
>backed out.

1.44 change was correct if user not set t_timeout directly
via special ioctl or comcontrol. By default t_timeout == 0 !!!
				 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This "fix" is _incorrect_, it obviously not fix this PR, becuase
t_timeout != 0 required for it. Moreover it cause modem hangs,
whan 1.44 code release it.

If user set t_timeout directly to != 0, he must know what he does
and not send PR int this case.

If t_timeout != 0 is needed, better way is increase it more,
maybe to 5 minutes f.e. than breaks tty.c code as occurse now.

P.S. Please not back out anything without discussion with
fix author (me) first.

- --
Andrey A. Chernov        : And I rest so composedly,  /Now, in my bed,
ache@astral.msk.su       : That any beholder  /Might fancy me dead -
FidoNet: 2:5020/230.3    : Might start at beholding me,  /Thinking me dead.
RELCOM Team,FreeBSD Team :         E.A.Poe         From "For Annie" 1849

-----BEGIN PGP SIGNATURE-----
Version: 2.6.2i

iQCVAwUBL9IyxuJgpPLZnQjrAQHSDQP+KNVljT3AhiYmn4Wp0bJj0ufygaU7QVZO
EDmA1I4bL+jt7+WJlIiCUOJ5bipNQh1BgD9mgWIcqPR5J63BWX2+lQY9/KXB+CWA
qVE14pYLzRhv72/uEJldvH0Gi4gFu9vtpBUe1WfpMp6wFXdN9iPytIJaudP0QiMX
EKHcO7N1qKk=
=TxZ/
-----END PGP SIGNATURE-----


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pj8BZqlSYQ>