Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Sep 2024 03:53:36 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f6e1b5679211 - main - e1000: remove NEEDGIANT from a couple sysctls
Message-ID:  <202409220353.48M3ra8D022490@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kbowling:

URL: https://cgit.FreeBSD.org/src/commit/?id=f6e1b567921187b9331bd71c86e94cf232dd7761

commit f6e1b567921187b9331bd71c86e94cf232dd7761
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-09-22 03:52:48 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-09-22 03:52:48 +0000

    e1000: remove NEEDGIANT from a couple sysctls
    
    These are internally locked already
    
    MFC after:      1 week
---
 sys/dev/e1000/if_em.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c
index 3d815348f5ec..768522a821bd 100644
--- a/sys/dev/e1000/if_em.c
+++ b/sys/dev/e1000/if_em.c
@@ -831,11 +831,11 @@ em_if_attach_pre(if_ctx_t ctx)
 	child = SYSCTL_CHILDREN(device_get_sysctl_tree(dev));
 
 	SYSCTL_ADD_PROC(ctx_list, child, OID_AUTO, "nvm",
-	    CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, sc, 0,
+	    CTLTYPE_INT | CTLFLAG_RW, sc, 0,
 	    em_sysctl_nvm_info, "I", "NVM Information");
 
 	SYSCTL_ADD_PROC(ctx_list, child, OID_AUTO, "fw_version",
-	    CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, 0,
+	    CTLTYPE_STRING | CTLFLAG_RD, sc, 0,
 	    em_sysctl_print_fw_version, "A",
 	    "Prints FW/NVM Versions");
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409220353.48M3ra8D022490>