Date: Sun, 23 Aug 2009 16:44:10 +0200 From: Christoph Mallon <christoph.mallon@gmx.de> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, Ed Schouten <ed@80386.nl>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Julian Elischer <julian@FreeBSD.org> Subject: Re: svn commit: r196451 - head/sys/netinet/ipfw Message-ID: <4A9155BA.9020808@gmx.de> In-Reply-To: <20090823230300.Q38728@delplex.bde.org> References: <200908230759.n7N7xS6g051165@svn.freebsd.org> <20090823080940.GT1292@hoeg.nl> <20090823230300.Q38728@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans schrieb:
> % */
> % int
> % ipfw_init(void)
> % {
> % int error = 0;
>
> This variable is not really used.
>
> Initialization in declaration. This mainly obfuscates the non-use of the
> variable.
Rather the opposite is true:
void f(void)
{
int error = 0; // GCC warns that error is unused
}
void g(void)
{
int error;
error = 0; // GCC is silent
}
In this case it does not help, because error is used. But an assignment
halfway down the function definitely would not improve the situation.
Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A9155BA.9020808>