Date: Wed, 12 Oct 2005 03:37:55 +0000 (UTC) From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/security/termlog Makefile distinfo Message-ID: <200510120337.j9C3btxf095784@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
csjp 2005-10-12 03:37:55 UTC
FreeBSD ports repository (src committer)
Modified files:
security/termlog Makefile distinfo
Log:
Fix a couple of problems on 64 bit platforms by importing 2.5:
Summary:
o Call va_start/va_end for each call to va_arg(). I have no idea why this
works on i386 but it shouldn't. This un-busts termlog on 64 bit
platforms.
o When allocating snp descriptors, allocate the proper size. Currently we
are allocating sizeof(struct utmp) when we really should be allocating
sizeof(struct snp_d). I can only imagine how this happen, but I am going
to guess it was a cut-and-paste-o. This helps un-busts termlog on 64 bit
architectures.
Fixes Submitted by: Eirik ?verby
While we are here:
o Open tty line with O_NONBLOCK
o Close the line fd after we attach to it as we dont need it. This closes
an fd leak.
o Remove comment about fd leak
Approved by: kris
Revision Changes Path
1.12 +1 -1 ports/security/termlog/Makefile
1.9 +2 -2 ports/security/termlog/distinfo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510120337.j9C3btxf095784>