Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Feb 2009 23:57:09 GMT
From:      Henrik Friedrichsen <hrkfdn@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/131322: [PATCH] audio/faad: install mp4ff library so that mpd plays mp4 files
Message-ID:  <200902022357.n12Nv98I028095@www.freebsd.org>
Resent-Message-ID: <200902030000.n1300IQE081718@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         131322
>Category:       ports
>Synopsis:       [PATCH] audio/faad: install mp4ff library so that mpd plays mp4 files
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 03 00:00:17 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Henrik Friedrichsen
>Release:        7.1-STABLE
>Organization:
>Environment:
FreeBSD kiwi.icecap 7.1-STABLE FreeBSD 7.1-STABLE #0: Thu Jan 29 23:20:34 CET 2009     root@kiwi.icecap:/usr/obj/usr/src/sys/PLUTONIUM  i386
>Description:
Per the latest faad2 sources from audiocoding.com, that project's maintainer has changed faad2 so that it does not build or ship a separate mp4ff library, however that library is now required by mpd to play MP4 files.
This patch will enable the build of a mp4ff library and will install it with it's headers.
Along with [1] this will fix the playback of mp4 files, otherwise mp4 playback is BROKEN in audio/musicpd.

For a further reference, see:
http://musicpd.org/mantis/view.php?id=1817

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131204
>How-To-Repeat:

>Fix:
Apply patch.

Patch attached with submission follows:

diff -Naur ./Makefile ../faad/Makefile
--- ./Makefile	2009-02-03 00:24:46.000000000 +0100
+++ ../faad/Makefile	2009-02-03 00:48:50.000000000 +0100
@@ -7,7 +7,7 @@
 
 PORTNAME=	faad2
 PORTVERSION=	2.6.1
-PORTREVISION=	1
+PORTREVISION=	2
 PORTEPOCH=	1
 CATEGORIES=	audio
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
@@ -40,4 +40,8 @@
 	@${ECHO_CMD} "SUBDIRS = libfaad common frontend" > \
 		${WRKSRC}/Makefile.am
 
+post-install:
+	${INSTALL_DATA} ${WRKSRC}/common/mp4ff/mp4ff.h ${PREFIX}/include/mp4ff.h
+	${INSTALL_DATA} ${WRKSRC}/common/mp4ff/mp4ff_int_types.h ${PREFIX}/include/mp4ff_int_types.h
+
 .include <bsd.port.post.mk>
diff -Naur ./files/patch-Makefile.am ../faad/files/patch-Makefile.am
--- ./files/patch-Makefile.am	1970-01-01 01:00:00.000000000 +0100
+++ ../faad/files/patch-Makefile.am	2008-11-16 04:11:26.000000000 +0100
@@ -0,0 +1,13 @@
+Index: common/mp4ff/Makefile.am
+===================================================================
+RCS file: /cvsroot/faac/faad2/common/mp4ff/Makefile.am,v
+retrieving revision 1.9
+diff -u -r1.9 Makefile.am
+--- common/mp4ff/Makefile.am	7 May 2006 18:09:00 -0000	1.9
++++ common/mp4ff/Makefile.am	16 Nov 2008 02:09:26 -0000
+@@ -1,4 +1,4 @@
+-noinst_LTLIBRARIES = libmp4ff.la
++lib_LTLIBRARIES = libmp4ff.la
+ 
+ libmp4ff_la_CFLAGS = -DUSE_TAGGING=1
+ 
diff -Naur ./pkg-plist ../faad/pkg-plist
--- ./pkg-plist	2009-02-03 00:24:46.000000000 +0100
+++ ../faad/pkg-plist	2009-02-03 00:44:41.000000000 +0100
@@ -1,7 +1,13 @@
 bin/faad
 include/faad.h
 include/neaacdec.h
+include/mp4ff.h
+include/mp4ff_int_types.h
 lib/libfaad.a
 lib/libfaad.la
 lib/libfaad.so
 lib/libfaad.so.0
+lib/libmp4ff.a
+lib/libmp4ff.la
+lib/libmp4ff.so
+lib/libmp4ff.so.0


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902022357.n12Nv98I028095>