Date: Thu, 11 Apr 2002 03:34:26 -0700 From: Peter Wemm <peter@wemm.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: "David O'Brien" <obrien@FreeBSD.org>, Marcel Moolenaar <marcel@xcllnt.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/gperf Makefile src/gnu/usr.bin/groff/src/devices/grodvi Makefile src/gnu/usr.bin/groff/src/devices/grohtml Makefile src/gnu/usr.bin/groff/src/devices/grolbp Makefile sr Message-ID: <20020411103426.E00123810@overcee.wemm.org> In-Reply-To: <20020411093353.GA42484@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote:
>
> --vtzGhvizbBRQ85DL
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Wed, Apr 10, 2002 at 10:15:28PM -0700, Peter Wemm wrote:
> > "David O'Brien" wrote:
> > > On Tue, Apr 09, 2002 at 09:48:21PM -0700, Marcel Moolenaar wrote:
> > > > On Mon, Apr 08, 2002 at 07:10:29PM -0700, David O'Brien wrote:
> > > > > On Mon, Apr 08, 2002 at 04:20:40PM -0700, Peter Wemm wrote:
> > > > > > > Please commit this as it does improve things. As Peter mention=
> ed it
> > > > > > > would be nice to add the libstdc++ dependancy also. But even w=
> /o tha
> > t,
> > > > > > > this patch is a help.
> > > > > >=20
> > > > > > No, do what Max Khon suggested. Use PROG_CXX like NetBSD does.
> > > > >=20
> > > > > Why can't we do both? If we can make PROG=3Dfoo do the right thing=
> in the
> > > > > common case we should make it do so.
> > > >=20
> > > > The common case is all C. That already works. If you do both, you
> > > > break the uncommon case, in which you have C++ source files (or at
> > > > least named like them) but want C linkage. You cannot use PROG=3D
> > > > anymore. This can only lead to a third one PROG_C, which is almost
> > > > exactly like PROG. This is confusing.
> > > >=20
> > > > I think only PROG_CXX is better. This automaticly means that PROG
> > > > is for C. Always...
> > >=20
> > > There is a patch that implements PROG=3D such that we can remove the
> > > explicit linkage of libstdc++. Unless someone writes and commits the
> > > PROG_CXX, we have no better option than to commit ru's patch.
> >=20
> > It is not "no better option than to commit ..." - nothing is broken.
> >=20
> > I have a PROG_CXX patch already FWIW.
> >=20
> I agree with all of the above, and I also have a working patch.
My version looked almost identical, but I haven't tested it. I've
been obsessed with a loader bug for a few days and not getting enough
sleep. (3 hours per day sucks after a while).
One thing that I did though was to actually set _CCLINK to either ${CC} or
${CXX} dependng on what $PROG was set. Either works I guess, and the user
Makefile interface is the same both ways. I tidied up a couple of other
loose ends too.
If you've buildworld tested it, please commit yours. We can haggle over
internals later. After that, I'm happy for the groff/gperf commit to be
backed out.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020411103426.E00123810>