Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Nov 2017 10:29:54 -0500
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Wojciech Macek <wma@semihalf.com>
Cc:        "Landon J. Fuller" <landonf@freebsd.org>, adrian@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>
Subject:   Re: svn commit: r326109 - in head/sys: conf dev/bhnd dev/bhnd/cores/chipc mips/conf modules/bhnd
Message-ID:  <20171124152954.2bsg6olctqc6fiqw@mutt-hbsd>
In-Reply-To: <CANsEV8dQBGbp%2B_G%2BJBLynSBjz9J3ct6=TfTB9U43pNcSd4CHEA@mail.gmail.com>
References:  <201711222310.vAMNAKmb048921@repo.freebsd.org> <CANsEV8dQBGbp%2B_G%2BJBLynSBjz9J3ct6=TfTB9U43pNcSd4CHEA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--qlowlqqkn4etpkdr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 24, 2017 at 10:21:17AM +0100, Wojciech Macek wrote:
> Hi,
>=20
> The patch breaks the build for ppc64. Could you please add missing
> ofw_bus_if.h to the Makefile?
>=20
> cc -isystem
> /home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp/=
usr/include
> -L/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tm=
p/usr/lib
> -B/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tm=
p/usr/lib
> --sysroot=3D/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.po=
werpc64/tmp
> -B/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tm=
p/usr/bin
> -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc
>  -DHAVE_KERNEL_OPTION_HEADERS -include
> /home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/sys/=
GENERIC64/opt_global.h
> -I. -I/home/wma/ppc64-freebsd/sys -fno-common -g -mlongcall
> -fno-omit-frame-pointer
> -I/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/sy=
s/GENERIC64
>  -MD  -MF.depend.chipc_gpio.o -MTchipc_gpio.o -mno-altivec -ffreestanding
> -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions
> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
> -Wno-uninitialized  -finline-limit=3D15000 -fms-extensions --param
> inline-unit-growth=3D100 --param large-function-growth=3D1000 -msoft-float
> -mcall-aixdesc  -std=3Diso9899:1999 -c
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c -o
> chipc_gpio.o
> In file included from /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:4=
0,
>                  from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:40:24: error:
> ofw_bus_if.h: No such file or directory
> cc1: warnings being treated as errors
> In file included from /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:4=
0,
>                  from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:71: warning: 'struct
> ofw_bus_devinfo' declared inside parameter list
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:71: warning: its scope
> is only this definition or declaration, which is probably not what you wa=
nt
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:72: warning: 'struct
> ofw_bus_devinfo' declared inside parameter list
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:74: error: expected '=
=3D',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_compat'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:75: error: expected '=
=3D',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_model'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:76: error: expected '=
=3D',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_name'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:77: error: expected '=
=3D',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_node'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:78: error: expected '=
=3D',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_type'
> In file included from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:115: error: field
> 'opd_obdinfo' has incomplete type
> *** [chipc_gpio.o] Error code 1
>=20
> make[4]: stopped in /home/wma/ppc64-freebsd/sys/modules/bhnd
> --- all_subdir_cardbus ---
> --- cardbus.o ---
> ctfconvert -L VERSION -g cardbus.o
> A failure has been detected in another branch of the parallel make

We've noticed this in our nightly build system as well. We've
implemented a fix here:

https://github.com/HardenedBSD/hardenedBSD/commit/76b37deb3a5f2c3aa014efadd=
4e78d748148b884

Thanks,

--=20
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

--qlowlqqkn4etpkdr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAloYOu8ACgkQaoRlj1JF
bu7IURAArT0XndGE4pociQNs3wi2GJc9AvLv/nWuG28W5jlvUe80XcuI6EWFX639
wqGgTSj4Uyy25paNz0un11KbO/fAqsUgP5ToC8rdsEk7gn1jPGm7hqkRW8TVSMvy
6b3+qIfmibBZdohkWQeSH5XzEdp8VLQIC/26fp1zQ2Wq2xdVRemJCxAnMGLyg3UU
Z62y7iUeIKhHloa2/NlPQkaii9xD8ROw1IJ1TPxvIUC7pTroiiH0Gcz8+2q7ZYPB
Jj+JIj0a1GmpVheUyZ+rdpBOVHAz0ICPSV8qAXMvJncEK6y3mt//fSkRl3hfMb3c
11spQDY+uXA9Bh66aNgEF6GcgjZ6pSTtvUixPzOtJSChjOGSpqjGaoRPaI/WtpTb
Gxxf4ZQ21KLuAOjs6SD778cpBrXRtPlp1l//D65U9sChTQbB2KbjZNI1vbbszQCT
tnJZqdZB97JjpjfF0biU3aPol/7vbZwdMsOLbqUSwGGZy5mrUsDfm64RKTgkGlP5
NKQ5V5f3MOpApfyQXTaZWPS5GraDf0SqeT4kNLJaAshVDrfRUhvKL+PccGKwl7XM
V4sL+rnKdY2sDQCLJZeri/m7Jv4UqqtC3lzll3urrBdNT2TZ5fYrZTef8KdP+MSv
Kal6uCbMbAFJsR+5uszjnIBNQRUGP+Ws5cHmu+Aim0HZJFO3jgI=
=+oyc
-----END PGP SIGNATURE-----

--qlowlqqkn4etpkdr--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171124152954.2bsg6olctqc6fiqw>