Date: Fri, 7 Feb 2014 16:20:15 GMT From: Reinier Schoof <reinier@skoef.nl> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/186536: lang/php5: support for overriding configure flags Message-ID: <201402071620.s17GKFAi011112@oldred.freebsd.org> Resent-Message-ID: <201402071630.s17GU0XU081486@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186536
>Category: ports
>Synopsis: lang/php5: support for overriding configure flags
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Feb 07 16:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Reinier Schoof
>Release: 9.2-RELEASE
>Organization:
>Environment:
FreeBSD x.x.x 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
I'm using poudriere to create my own packages and I would like to be able to override the default CONFIGURE_ARGS that are given to lang/php5, for instance from my /etc/make.conf like so:
.if ${.CURDIR:M*/lang/php5}
CONFIGURE_ARGS=--enable-fd-setsize=32768
.endif
However, the CONFIGURE_ARGS in /usr/ports/lang/php5/Makefile don't allow to be overridden, unless the attached diff is applied.
I don't see any harm in applying my patch, so if you don't either, please do!
>How-To-Repeat:
Put the following in /etc/make.conf:
CONFIGURE_ARGS=--enable-fd-setsize=32768
Build php
make -C /usr/ports/lang/php5
and see how the fd-setsize doesn't show up in configure arguments
>Fix:
Apply this diff to /usr/ports/lang/php5/Makefile:
--- Makefile.orig 2014-01-12 14:36:37.978364561 +0100
+++ Makefile 2014-01-12 14:31:57.075042793 +0100
@@ -23,7 +23,7 @@
LIB_DEPENDS= libpcre.so:${PORTSDIR}/devel/pcre
-CONFIGURE_ARGS= \
+CONFIGURE_ARGS+= \
--with-layout=GNU \
--localstatedir=/var \
--with-config-file-scan-dir=${PREFIX}/etc/php \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402071620.s17GKFAi011112>