Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Apr 2026 20:25:02 +0300
From:      Dima Panov <fluffy@FreeBSD.org>
To:        Konstantin Belousov <kib@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   git: 3a01e1e1a50c - main - msun/aarch64: convert fenv functions to proper linkage
Message-ID:  <31e15546-79b2-4109-998e-c5f981957044@FreeBSD.org>
In-Reply-To: <adPn0dChJmSObjby@kib.kiev.ua>
References:  <69caafbb.408c4.7b20a1e1@gitrepo.freebsd.org> <1f2ad4f0-a4ab-4f15-a779-5f1a6db9912b@FreeBSD.org> <adPaSi8u98pRvSeq@kib.kiev.ua> <8022afad-9cee-4ade-8b56-ef5b7feb6e16@FreeBSD.org> <adPjEp0ZW5H9eEXK@kib.kiev.ua> <ca44aaf8-59c6-4d15-875b-ad45f8ed7347@FreeBSD.org> <adPn0dChJmSObjby@kib.kiev.ua>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]


On 06.04.2026 20:05, Konstantin Belousov wrote:
> diff --git a/lib/msun/arm/Makefile.inc b/lib/msun/arm/Makefile.inc
> index 6e3ddb351dd3..e155f1a2cae4 100644
> --- a/lib/msun/arm/Makefile.inc
> +++ b/lib/msun/arm/Makefile.inc
> @@ -1,5 +1,4 @@
> LDBL_PREC = 53
> -SYM_MAPS += ${.CURDIR}/arm/Symbol.map

Nope, amd64 is also have Symbol.map included in Makefile.inc

--- a/lib/msun/aarch64/Makefile.inc
+++ b/lib/msun/aarch64/Makefile.inc
@@ -12,3 +12,5 @@ CFLAGS+=-DUSE_BUILTIN_FMIN

CFLAGS+=-DUSE_BUILTIN_SQRTF
CFLAGS+=-DUSE_BUILTIN_SQRT
+
+SYM_MAPS += ${.CURDIR}/aarch64/Symbol.map

and no need to patch msun/Makefile with additional checks/includes

--
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD, @fluffy:matrix-dev.freebsd.org)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team


[-- Attachment #2 --]
<html><head><meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=no"></head><body><div id="CanaryBody"><br> <br>On 06.04.2026 20:05, Konstantin Belousov wrote: <br><blockquote type="cite">diff --git a/lib/msun/arm/Makefile.inc b/lib/msun/arm/Makefile.inc <br>index 6e3ddb351dd3..e155f1a2cae4 100644 <br>--- a/lib/msun/arm/Makefile.inc <br>+++ b/lib/msun/arm/Makefile.inc <br>@@ -1,5 +1,4 @@ <br>LDBL_PREC = 53 <br>-SYM_MAPS += ${.CURDIR}/arm/Symbol.map <br></blockquote> <br>Nope, amd64 is also have Symbol.map included in Makefile.inc <br> <br>--- a/lib/msun/aarch64/Makefile.inc <br>+++ b/lib/msun/aarch64/Makefile.inc <br>@@ -12,3 +12,5 @@ CFLAGS+=-DUSE_BUILTIN_FMIN <br> <br> CFLAGS+=-DUSE_BUILTIN_SQRTF <br> CFLAGS+=-DUSE_BUILTIN_SQRT <br>+ <br>+SYM_MAPS += ${.CURDIR}/aarch64/Symbol.map <br> <br>and no need to patch msun/Makefile with additional checks/includes <br> <br>-- <br>Sincerely, <br>Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD, @fluffy:matrix-dev.freebsd.org) <br>(desktop, kde, x11, office, ports-secteam)@FreeBSD team <br> <br></div></body></html>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31e15546-79b2-4109-998e-c5f981957044>