Date: Thu, 12 Nov 2015 03:05:38 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r401299 - head/security/openssh-portable/files Message-ID: <20151112030538.GA71430@FreeBSD.org> In-Reply-To: <5643FC04.4020001@FreeBSD.org> References: <201511112121.tABLLjO6051679@repo.freebsd.org> <20151112021225.GB43902@FreeBSD.org> <5643FC04.4020001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 11, 2015 at 06:40:04PM -0800, Bryan Drewery wrote: > On 11/11/15 6:12 PM, Alexey Dokuchaev wrote: > > On Wed, Nov 11, 2015 at 09:21:45PM +0000, Bryan Drewery wrote: > >> New Revision: 401299 > >> URL: https://svnweb.freebsd.org/changeset/ports/401299 > >> > >> Log: > >> Make portlint stop spamming me. It's gotten quite silly. > > > > [...] > > As John had said on IRC, this helps to get consistent patches, because > > prople rarely think about these little details ("repo churn? who cares > > about it") and portlint(1) warning gives them simple and straight course > > of action. Yet it's true that the check could probably be made somewhat > > smarter than simple grepping for "UTC". > > > > TL;DR: instead of adding noise to the patches, it's better to improve > > portlint(1). Or learn how to ignore its warnings. ;-) > > We should just ignore portlint at our own discretion since it grows > stupid warnings like this? Ignoring stupid warnings was listed second after improving portlint(1). But yes, portlint(1) can be wrong, so, answering your question, yes, "we should just ignore portlint at our own discretion". Every software has bugs, checkers can give false positives. > Mission accomplished? Mission is not to follow *everything* any lint tool tells you about your code and stuff. The mission is to have that stuff working and neat, with some tools' help or without. That's why I think that adding noise to patches is wrong approach: it makes the stuff (patches) less neat and thus portlint(1) warnings more important, while it should be the other way around. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151112030538.GA71430>