Date: Fri, 21 Apr 2006 21:23:22 -0400 From: Tom Rhodes <trhodes@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c Message-ID: <20060421212322.2f5b3fa8.trhodes@FreeBSD.org> In-Reply-To: <20060421161321.J44089@fledge.watson.org> References: <200604210714.k3L7EQhD046878@repoman.freebsd.org> <20060421161321.J44089@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Apr 2006 16:15:15 +0100 (BST) Robert Watson <rwatson@FreeBSD.org> wrote: > > On Fri, 21 Apr 2006, Tom Rhodes wrote: > > > trhodes 2006-04-21 07:14:25 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/ufs/ffs ffs_vfsops.c > > Log: > > Remove what I believe are two useless ifdefs. If a user or administrator > > enables multilabel, or any option for that matter, most likely they have > > a reason. This will allow users to see that mulilabel is enabled via an > > issued "mount" command and remove an annoying warning - printed only when > > a MAC kernel is not installed - on boot up. > > This seems incorrect to me. You have also removed the warnings associated > with trying to use multi-label and ACL-enabled file systems on kernels not > configured to support them, which can lead to highly undesirable behavior, > hence the warnings. The mount point flags are intended to reflect the current > mode of operation, and setting the flags when the operational mode isn't > supported doesn't seem right. > Might I inquire to the "undesirable behavior" is? When I was playing around with this, I noticed no real effect, at least not in a negative way. These are the reasons I made this change, and you have an email from me about this too: 1: If I change the newfs flags while installing FreeBSD, I would think I have a clear reason for adding "-l." 2: A standard "mount" command does not show multilabel enabled until a MAC kernel is installed. Most likely if I enabled it, I plan to build a kernel. 3: The correct fix would be to offer a MAC kernel in sysinstall, similar to how Linux offers one to enable or disable SELinux (seen with Redhat and CentOS installs). 4: With regards to number 2, I think the option should at least be spit out with all other options when using mount(8) to review file system information. I'll revert it if you feel strongly about it; however, I want it to be known what my opinion is. And I find the warnings extremely annoying and have answered at least one question as to why "mount don't show me correct output." Yes, real quote. :) -- Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060421212322.2f5b3fa8.trhodes>