Date: Wed, 13 Jun 2018 21:59:49 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: Juli Mallett <juli@northcloak.com>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol Message-ID: <201806140459.w5E4xn93043001@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfqCUo24oWp1J-XYCAt2JDm_qZrs26Pw6nhyo2V9dNY9=w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, Jun 13, 2018 at 9:31 PM, Juli Mallett <juli@northcloak.com> wrote: > > > On 13 June 2018 at 20:28, Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net > > > wrote: > > > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > >> > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > > >> > > > Author: imp > >> > > > Date: Wed Jun 13 22:00:02 2018 > >> > > > New Revision: 335091 > >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > >> > > > > >> > > > Log: > >> > > > Make it possible to use print_controller from another program > >> > > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its > >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not > >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > >> > > > interfaces. > >> > > > > >> > > > Sponsored by: Netflix > >> > > > Differential Revision: https://reviews.freebsd.org/D15371 > >> > > > > >> > > > Added: > >> > > > head/sbin/nvmecontrol/identify_ext.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify > >> .c > >> > > > head/sbin/nvmecontrol/nc_util.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > >> changed) > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > ... > >> > > > >> > > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > >> > > r335089, head/sbin/nvmecontrol/util.c) > >> > > > ============================================================ > >> > > ================== > >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > >> > > (r335089, copy source) > >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > >> 2018 > >> > > (r335091) > >> > > > @@ -1,7 +1,8 @@ > >> > > > /*- > >> > > > - * Copyright (c) 2017 Netflix, Inc > >> > > > - * All rights reserved. > >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > >> > > > * > >> > > > + * Copyright (C) 2018 Netflix > >> > > > >> > > You moved a copyright forward, that is not proper to do. > >> > > > >> > > >> > Thought it was. I honestly don't care where (nor does my employer), so > >> if > >> > you want to tweak it to be more conforming, be my guest. > >> > >> You can add a new date to the end of a list, but you should always > >> retain the oldest date, and many opinions are that all dates should > >> be retained unless they are continuous. > >> > > > > Do you have a citation for this, Rod? I ask because my impression was > > that although it has often been done, and at one point may legitimately > > have been required, it is not any longer so. I'd love to have a concrete > > source on this, though. > > > > The project just does oldest and newest with a -. > > The US copyright office says you just need the newest. There's some concern Can you be more specific on where on the US copyright offices site? > elsewhere is different, but I have nothing concrete on that. > > I've never heard Rod's advice in the 20 years I've been minding the store > here and at small shops I've worked at. And have any of these places actually read the text of USC 17? > Warner > > > > > > > It would be much simpler for you to commit: > >> - * Copyright (C) 2018 Netflix > >> + * Copyright (C) 2017-2018 Netflix > >> > >> Than for me to get approval: bde, phk. > >> > >> Thanks. > >> Rod > >> > >> > > >> > > Not sure about dropping the , Inc either. > >> > > >> > > >> > Doesn't matter. Different Netflix committers do different things and I > >> was > >> > trying to move towards uniformity. > >> > >> Ok > >> > >> > Warner > >> > >> -- > >> Rod Grimes > >> rgrimes@freebsd.org > >> > >> > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806140459.w5E4xn93043001>