Date: Wed, 22 May 2019 23:04:21 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502238 - in head/x11: . py-pyscreenshot Message-ID: <cf3adff4-0206-59aa-f7cc-edec121a022d@FreeBSD.org> In-Reply-To: <be8342c1-942f-c5ab-c9ce-03888ef14623@FreeBSD.org> References: <201905220108.x4M18hFR056638@repo.freebsd.org> <20190522070947.GA31138@FreeBSD.org> <95155332-148d-38f0-7fee-f07e931c1682@FreeBSD.org> <be8342c1-942f-c5ab-c9ce-03888ef14623@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22/05/2019 10:07 pm, Steve Wills wrote: > Hi, > > On 5/22/19 3:16 AM, Kubilay Kocak wrote: >> pyscreenshots setup.py doesn't reference pillow, but a dependent port > > pyscreenshot/plugins/wxscreen.py looks like it does: > > from PIL import Image > > which I think comes from graphics/py-pillow. Am I missing something? In that case nope, upstream should list pillow in install_requires, unless its optional, in which case extras_require >> for which this was added (pyvirtualdisplay) does. I'm guessing it was >> inadvertent. >> >> I've already send Steve an email mentioning it > > This is the only email I saw. > >> Either way, not adding a port because the pkg-descr was wrong (I dont >> think it is however, given it doesn't depend on pillow) is a bit much. >> >> We'd just amend the pkg-descr not to make the claim thereby restoring >> balance to your force > > Any suggestions on what pkg-descr should say? Probably something like from upstreams setup.pylong_description (README): The pyscreenshot module can be used to copy the contents of the screen to a PIL_ or Pillow_ image memory using various back-ends. Features: * Cross-platform wrapper * Capturing the whole desktop * Capturing an area * saving to PIL_ or Pillow_ image memory > Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cf3adff4-0206-59aa-f7cc-edec121a022d>