Date: Sat, 19 Dec 2015 13:53:32 -0500 From: "Jonathan T. Looney" <jtl@freebsd.org> To: Kristof Provost <kristof@sigsegv.be>, Randall Stewart <rrs@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks Message-ID: <D29B1112.4DD53%jlooney@juniper.net> In-Reply-To: <3E097253-0E8E-4A50-B1BD-8C9A280E6CD0@sigsegv.be> References: <201512160056.tBG0ujqA067178@repo.freebsd.org> <3E097253-0E8E-4A50-B1BD-8C9A280E6CD0@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 12/18/15, 3:54 PM, "owner-src-committers@freebsd.org on behalf of Kristof Provost" <owner-src-committers@freebsd.org on behalf of kristof@sigsegv.be> wrote: > >> On 16 Dec 2015, at 01:56, Randall Stewart <rrs@freebsd.org> wrote: >> >> Author: rrs >> Date: Wed Dec 16 00:56:45 2015 >> New Revision: 292309 >> URL: https://svnweb.freebsd.org/changeset/base/292309 >> >> Log: >> First cut of the modularization of our TCP stack. Still >> to do is to clean up the timer handling using the async-drain. >> Other optimizations may be coming to go with this. Whats here >> will allow differnet tcp implementations (one included). >> Reviewed by: jtl, hiren, transports >> Sponsored by: Netflix Inc. >> Differential Revision: D4055 > >I suspect this commit broke my machine. I run VIMAGE jails, and see the >following panic as soon as the first jails starts: I think Randall is now (or soon will be) on holiday. Can you try the patch from https://reviews.freebsd.org/D4645 (also attached) and let me know if that fixes the problem? Thanks! Jonathan [-- Attachment #2 --] Index: sys/netinet/tcp_subr.c =================================================================== --- sys/netinet/tcp_subr.c (revision 292468) +++ sys/netinet/tcp_subr.c (working copy) @@ -593,10 +593,6 @@ if (hhook_head_register(HHOOK_TYPE_TCP, HHOOK_TCP_EST_OUT, &V_tcp_hhh[HHOOK_TCP_EST_OUT], HHOOK_NOWAIT|HHOOK_HEADISINVNET) != 0) printf("%s: WARNING: unable to register helper hook\n", __func__); - /* Setup the tcp function block list */ - TAILQ_INIT(&t_functions); - rw_init_flags(&tcp_function_lock, "tcp_func_lock" , 0); - register_tcp_functions(&tcp_def_funcblk, M_WAITOK); hashsize = TCBHASHSIZE; TUNABLE_INT_FETCH(tcbhash_tuneable, &hashsize); if (hashsize == 0) { @@ -675,6 +671,10 @@ tcp_rexmit_slop = TCPTV_CPU_VAR; tcp_finwait2_timeout = TCPTV_FINWAIT2_TIMEOUT; tcp_tcbhashsize = hashsize; + /* Setup the tcp function block list */ + TAILQ_INIT(&t_functions); + rw_init_flags(&tcp_function_lock, "tcp_func_lock" , 0); + register_tcp_functions(&tcp_def_funcblk, M_WAITOK); if (tcp_soreceive_stream) { #ifdef INET
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D29B1112.4DD53%jlooney>