Date: Sun, 22 Jan 2012 18:35:36 -0500 From: Eitan Adler <eadler@freebsd.org> To: ohauer@freebsd.org, Ports Management Team <portmgr@freebsd.org> Cc: cvs-ports@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: ports/multimedia/acidrip Makefile ports/math/algotutor Makefile ports/sysutils/apt Makefile ports/graphics/asciio Makefile ports/devel/autodia Makefile ports/www/awffull Makefile ports/devel/bazaar Makefile ports/www/bigbluebutton Mak Message-ID: <CAF6rxgnNy%2B_6FX0e0byGdUX-yQOsHufB%2B41G-UF4dwebh6kccQ@mail.gmail.com> In-Reply-To: <4F1C897E.1050805@FreeBSD.org> References: <CAF6rxg=Wnh90=Nr0iuaz_HjWfenavuq1FqAHJ6Q3KpQs4sUrHA@mail.gmail.com> <4F1C897E.1050805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 22, 2012 at 5:11 PM, Olli Hauer <ohauer@freebsd.org> wrote:
> Hm, if I read the diffs Eitan has changed from `=3D' to `:=3D' so I think=
you mean
> =C2=A0Why should we stop using `=3D'?
A few people on portmgr expressed their preferences that we stop using
both =3D and :=3D and instead duplicate contents of the variables. Instead
of continuing to guess their reasoning I'll let someone with a hat
reply :)
>>> Instead, we should fix portlint(1) to offer this obvious thing instead =
of
>>> duplicating two variables like it bogusly does now.
>>
>> The concern is that someone would add something extra to BUILD_DEPENDS
>> without thinking about it and thus add extra bogus RUN_DEPENDS. I'm
>> uncertain if there other additional reasons that portmgr dislikes :=3D
>
> It doesn't matter if you have RUN_DEPENDS=3D${BUILD_DEPENDS} or RUN_DEPEN=
DS:=3D${BUILD_DEPENDS},
> if someone adds additional `something' to BUILD_DEPENDS then it is in bot=
h cases also in RUN_DEPENDS but `:=3D` preserves including additional depen=
dencies from `something'.
This is why my commit unbreaks ports but it is unrelated to the point
I made at the end of my commit log.
> Maybe the following section in the PH will make things clearer.
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefil=
e-depend.html#AEN2173
If I understand portmgr@ correctly this paragraph is bogus and should
read, "instead explicitly list the dependancies".
--=20
Eitan Adler
Source & Ports committer
X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnNy%2B_6FX0e0byGdUX-yQOsHufB%2B41G-UF4dwebh6kccQ>