Date: Sat, 09 Jul 2005 15:46:12 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: Poul-Henning Kamp <phk@haven.freebsd.dk>, freebsd-current@FreeBSD.org, current@FreeBSD.org Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix Message-ID: <20514.1120916772@phk.freebsd.dk> In-Reply-To: Your message of "Sat, 09 Jul 2005 09:32:11 EDT." <200507090932.12973.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200507090932.12973.jhb@FreeBSD.org>, John Baldwin writes: >On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote: >> This is an attempt to fix an boot0cfg/fdisk issue which I have >> overlooked. >> >> The patch adds a g_ctl method to geom_mbr and makes boot0cfg and >> fdisk use it to modify the MBR if possible. >> >> Please test and report ASAP in order to get this solution into >> RELENG_6 > >Only thing I noted is that it seems that you changed boot0 to always only >write 512 bytes which means it will break trying to use boot0cfg to install >boot0ext (which is 2 sectors). Perhaps you should check the filesize of the >boot you are writing and if it's > 512, write the other data with a write(2) >after the g_ctl()? Perhaps I don't see quite understand what your g_ctl() is >doing though. Damn, didn't think of that... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20514.1120916772>