Date: Thu, 23 Mar 2023 07:53:27 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ed52baf51bd1 - main - _endian.h: Include sys/ctypes.h for visibility macros Message-ID: <010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@email.amazonses.com> In-Reply-To: <202303220226.32M2QLoe029463@gitrepo.freebsd.org> References: <202303220226.32M2QLoe029463@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/21/23 19:26, Warner Losh wrote: > [...] > This had the side effect of sometimes (in the traditional BSD > compliation environment) > #if BYTE_ORDER == LITTLE_ENDIAN > and > #if BYTE_ORDER == BIG_ENDIAN > both being true because none of these were defined. This fixes > that. It also fixes including it after <stdio.h> but not before. Would it be worth adding #if LITTLE_ENDIAN == BIG_ENDIAN #error Endian defines are broken! #endif just to ensure that any future issues show up quickly? -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000>