Date: Fri, 13 Nov 2015 13:43:45 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Randall Stewart <rrs@netflix.com> Cc: "Alexander V. Chernikov" <melifaro@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <56465991.5090906@FreeBSD.org> In-Reply-To: <B554CD5E-6B2A-4E63-BB83-ECB267ABCB92@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <CCAE1243-3DC1-4077-BC55-AA6EA7750181@netflix.com> <56465003.8070709@FreeBSD.org> <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> <B554CD5E-6B2A-4E63-BB83-ECB267ABCB92@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable On 11/13/2015 1:24 PM, Randall Stewart wrote: > Looking at the patch, we need a define of your >=20 > _callout_stop_safe >=20 > and we need to switch >=20 > callout_stop()=92s define to use the new _callout_stop_safe() For both cases, there would be no reason to have new code call my wrapper. The defines in my patch are fine for new code. The "new" _callout_stop_safe function is just for existing modules. I think the historical consensus is to not commit my patch though as people should recompile their modules when the kernel is updated, before rebooting into the new kernel even. >=20 > R > On Nov 13, 2015, at 4:20 PM, Randall Stewart <rrs@netflix.com > <mailto:rrs@netflix.com>> wrote: >=20 >> No alexander=92s panic=92s are because the >> LLREF >> is done if (callout_stop()) >> >> But now if it was not running -1 is returned.. >> >> Try the patch I just sent.. >> >> R >> On Nov 13, 2015, at 4:02 PM, Bryan Drewery <bdrewery@FreeBSD.org >> <mailto:bdrewery@FreeBSD.org>> wrote: >> >>> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>>> Bryan: >>>> >>>> This looks like a decent thing to do.. >>>> >>>> Still wondering why changing the callout.h header file would not >>>> have caused >>>> things to recompile to pick up the new argument.. >>>> >>>> We can do it this way though it looks fine. >>>> >>>> You want to commit it or I? >>> >>> Well your change is totally safe for compiling. It's just not KBI >>> backwards compat for older modules. This is not typically a problem b= ut >>> I think in this case it is worth doing to avoid random data coming in= to >>> the 'drain' argument if loading an older module. >>> >>> I'll do a test build and commit it. Perhaps this is what was leading = to >>> Alexander's panics. >>> >>> I haven't analyzed the return value issue at all. >>> >>> --=20 Regards, Bryan Drewery --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRlmRAAoJEDXXcbtuRpfPX6EH/RW325PZr6YxDWWyxgac5lj5 AE6VtdT8Df6wiF8lC+Jv5VwgzT7xG+SC21K/wXjsxIkivtyug3PEbUyASz6CmUTv /onaL9cwFL9+ozIoJTGXSKgT7PQRQbbalQmYgXe5DY+DuZU9j1ij/WbFcgSZ9w8f ySjH41nqTgN0JicD7PyaM8Dj+tmWKa/+ZFYr5WMyqIvJ/7LNltmftbstAuL8OiGo +s2bD24QB2SgMiD7+t70mbHcv76eyeku+ZV+H9Oo1HraCqcw76uKjrrSt6fwMfnL Nyiaohho69XVLhWEFIgmbtFEvpcVtu4t4ttM9OyITkOr0JjT6cXajFzwxcU6Fjg= =pVGx -----END PGP SIGNATURE----- --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56465991.5090906>