Date: Fri, 22 Jul 2016 18:24:41 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au>, Ngie Cooper <yaneurabeya@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, Ruslan Bukin <br@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r303188 - head/share/mk Message-ID: <c7ca6170-c5f2-9353-6b3d-da30ca077871@FreeBSD.org> In-Reply-To: <20160723100100.K1644@besplex.bde.org> References: <201607221500.u6MF0c3S037470@repo.freebsd.org> <1980140.IgFQbb5iVz@ralph.baldwin.cx> <20160723073428.K1265@besplex.bde.org> <CAGHfRMCjqR3YDHRvaA-0=VQHXmkd%2Bh6aj5BveQHPscfA8AAkbg@mail.gmail.com> <20160723100100.K1644@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs Content-Type: multipart/mixed; boundary="3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au>, Ngie Cooper <yaneurabeya@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, Ruslan Bukin <br@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <c7ca6170-c5f2-9353-6b3d-da30ca077871@FreeBSD.org> Subject: Re: svn commit: r303188 - head/share/mk References: <201607221500.u6MF0c3S037470@repo.freebsd.org> <1980140.IgFQbb5iVz@ralph.baldwin.cx> <20160723073428.K1265@besplex.bde.org> <CAGHfRMCjqR3YDHRvaA-0=VQHXmkd+h6aj5BveQHPscfA8AAkbg@mail.gmail.com> <20160723100100.K1644@besplex.bde.org> In-Reply-To: <20160723100100.K1644@besplex.bde.org> --3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 7/22/2016 5:25 PM, Bruce Evans wrote: > On Fri, 22 Jul 2016, Ngie Cooper wrote: >=20 >> On Fri, Jul 22, 2016 at 2:57 PM, Bruce Evans <brde@optusnet.com.au> >> wrote: >> ... >>>>> +# GCC 6.1.0 >>>>> +.if ${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 6010= 0 >>>>> +CWARNFLAGS+=3D -Wno-error=3Dunused-const-variable=3D >>>>> -Wno-error=3Dnonnull-compare -Wno-error=3Dshift-negative-value >>>>> -Wno-error=3Dmisleading-indentation -Wno-error=3Dtautological-compa= re >>>>> +.endif >>>> >>>> >>>> Extra trailing =3D in the first one as well? >>> >>> I don't see one. I see only unreadably long lines containing unreada= bly >>> unordered flags. Perhaps your mail client mangled the line splitting= , >>> but the above quite displays OK in mutt and vi here (except mutt make= s >>> the line wrapping especially ugly by highlighting it). >> >> Look for "-Wno-error=3Dunused-const-variable=3D". >=20 > It is not trailing :-). It is only trailing in the above quote and > apparently in the mail as seen by jhb because some mail programs mangle= > the formatting worse than others. In the above quote as seen by me > in EDITOR=3Dvi, the long line is split and each part is quoted. But in= > the previous quote, the line wasn't split. Since it was unreadable > by me, I used the editor search function to check if it had a trailing > '=3D' using a regexp, and none was found. It's not a mail issue. It is in the actual file. See https://svnweb.freebsd.org/base/head/share/mk/bsd.sys.mk?r1=3D303188&r2=3D= 303187&pathrev=3D303188 and https://svnweb.freebsd.org/base/head/share/mk/bsd.sys.mk?revision=3D30318= 8&view=3Dmarkup&pathrev=3D303188#l119 Specifically "-Wno-error=3Dunused-const-variable=3D", the first value. --=20 Regards, Bryan Drewery --3KrF1axrX0xGX63RMlHQPaAmMCHPOLCLf-- --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXksdZAAoJEDXXcbtuRpfPnYkIANN/gpwkavD5NUHntyP7F1DW e9r3K8caZkOulpN0MYVdlHe6NP1K5ktLS/JDrM/4+iByNAuBIYI9BxCfbtGP8UVA Qm1a0Zj+VGtK0AVm1P4fAz6i0ZZG5FNdeOf4vDDMNH+/We9y79kLlIhDHLWRM9T8 5fKQbIiIRDQOIbV1ZJ9NNdImbG931hSkA/dFQSDpUckNykIbK9pLGdP/NyHeGJ5Y J6y/dJThxEMZjcXuODL/tFoxUmQ8t4fFb/L+baZ1cSu1Bb4jL8R3jWaGKvo+l4EM uQkM4fGZ+hg5YKy8tfzomIBooo+PwLXnhgq6EiGmVKYmIoVnHhhgFTU31j0gE9o= =UudZ -----END PGP SIGNATURE----- --hWg8axHEw5p9tjwWoIrq85ucH17TTiRqs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c7ca6170-c5f2-9353-6b3d-da30ca077871>