Date: Sat, 3 Mar 2012 12:48:13 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Jung-uk Kim <jkim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232416 - in head/sys: amd64/conf i386/conf Message-ID: <20120303121225.O1691@besplex.bde.org> In-Reply-To: <201203030011.q230Blc9053789@svn.freebsd.org> References: <201203030011.q230Blc9053789@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 3 Mar 2012, Jung-uk Kim wrote:
> Log:
> Add VESA option to GENERIC for amd64 and i386.
>
> MFC after: 1 month
Any chance of adding it without style bugs?
> Modified: head/sys/amd64/conf/GENERIC
> ==============================================================================
> --- head/sys/amd64/conf/GENERIC Fri Mar 2 23:54:11 2012 (r232415)
> +++ head/sys/amd64/conf/GENERIC Sat Mar 3 00:11:46 2012 (r232416)
> @@ -168,6 +168,7 @@ device psm # PS/2 mouse
> device kbdmux # keyboard multiplexer
>
> device vga # VGA video card driver
> +options VESA # add support for VESA BIOS Extensions
>
> device splash # Splash screen and screen saver support
1. "options" lines are normally formatted with a space and a tab after
"options", so that you can add comment them out without messing up
the indentation of their comments. This line is formatted with 2
tabs.
2. "options" lines are normally formatted with comments starting in
column 40 (5 tab positions). This line is formatted with its comment
starting in column 32.
3. Comments in "options" lines are normally capitalized. This one is not.
4. "options" lines are normally sorted together. This one is sorted near
its device. There is something to be said for sorting options near
their devices, but formatting for "device" lines is sloppier and
interacts badly with normal formatting for "options" lines.
1a. "device" lines are normally formatted with 2 tab after "options".
This allows commenting them out with "#" without messing up the
indentation of their comments, but "# " messes it up.
2a. "device" lines are normally formatted with comments starting in
column 32 (4 tab positions).
3a. Comments in "device" lines are normally capitalized too, but now the
first word in the comment is more usually an proper name or an acronym,
and it isn't so clear that the capitalization is not just to spell these
normally. The new line has extensive capitalization for proper names
and acronyms in "VESA BIOS Extensions", but noe for "Add".
4a. Sorting is more random for "device" lines than for "options" lines.
There is fairly random sorting for just the 4 devices visible in this
diff. Dependencies for devices are more complicated and are barely
hinted at by the grouping and ordering of the device lines. Anything
except alphabetical sorting becomes unreadable in long lists.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120303121225.O1691>