Date: Wed, 17 Jan 2018 19:29:06 +0100 From: =?utf-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> To: Adam Weinberger <adamw@adamw.org> Cc: freebsd-ports@freebsd.org Subject: Re: Help with versioning scheme Message-ID: <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de> In-Reply-To: <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org> References: <F35F7011-4DDA-4BD4-93FB-BE75ECD49827@waschbuesch.de> <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Adam,
> Am 17.01.2018 um 19:19 schrieb Adam Weinberger <adamw@adamw.org>:
> Hi Martin,
>=20
> You don't want to use the upstream version to represent PORTREVISION. =
PORTREVISION is for when you need to force rebuilds of the port itself, =
and so tying it to upstream would make it impossible to bump it =
ourselves.
>=20
> Why do you need to ignore the fourth digit? It's perfectly valid for =
our purposes.
So far, I had (because it coincided with their version number) used it =
to provide SO_VER. But that breaks now:
---
# Created by: adamw
# $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z =
sunpoet $
PORTNAME=3D lz4
PORTVERSION=3D 1.8.1
DISTVERSIONPREFIX=3D v
PORTEPOCH=3D 1
CATEGORIES=3D archivers
PKGNAMEPREFIX=3D lib
MAINTAINER=3D martin@waschbuesch.de
COMMENT=3D LZ4 compression library, lossless and very fast
LICENSE=3D BSD2CLAUSE GPLv2
LICENSE_COMB=3D multi
USES=3D gmake pathfix pkgconfig
USE_GITHUB=3D yes
USE_LDCONFIG=3D yes
#PATHFIX_MAKEFILEIN=3D Makefile
ALL_TARGET=3D default # don't remove this
SO_VER=3D ${PORTVERSION}
PLIST_SUB+=3D SO_VER=3D${SO_VER} SO_VER_MAJ=3D${SO_VER:R:R}
LIBDIR=3D ${PREFIX}/lib
post-patch:
@${FIND} ${WRKSRC} -name Makefile | ${XARGS} ${REINPLACE_CMD} \
-e '/^MANDIR :=3D/s|share/||'
@${REINPLACE_CMD} -e '/^all:/s/$$/ liblz4.pc/' \
${WRKSRC}/lib/Makefile
@${REINPLACE_CMD} -e '/^all:/s|fullbench.*||' \
${WRKSRC}/programs/Makefile
post-install:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/lz4*
${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblz4.so.${SO_VER}
.include <bsd.port.mk>
---
Manually specifying the SO_VER seems also very weird.
I am sorry if these questions seem clumsy - I am not terribly =
experienced with porting stuff, but eager to learn.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D3D2C74D-DA67-4B8D-96C3-4E1E2928D815>