Date: Fri, 3 Jun 2016 09:21:25 +0200 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416270 - head/net/rsync Message-ID: <20160603092125.2476cdcae34209c83d62ae91@FreeBSD.org> In-Reply-To: <8D42CA4C-75EC-4402-BA69-DF20E3F62462@adamw.org> References: <201606020735.u527ZoAj066577@repo.freebsd.org> <8D42CA4C-75EC-4402-BA69-DF20E3F62462@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Adam Weinberger <adamw@adamw.org> wrote: > > On 2 Jun, 2016, at 1:35, Emanuel Haupt <ehaupt@FreeBSD.org> wrote: > > > > Author: ehaupt > > Date: Thu Jun 2 07:35:49 2016 > > New Revision: 416270 > > URL: https://svnweb.freebsd.org/changeset/ports/416270 > > > > Log: > > Fix the logic of the POPT_PORT option. > > > > - POPT_CONFIGURE_WITH should actually be POPT_PORT_CONFIGURE_WITH > > - The whole ^POPT block logic is reversing the logic > > - Bump PORTREVISION since we have a change of dependencie > > > > PR: 209837 (based on) > > Submitted by: Martin Birgmeier <la5lbtyi@aon.at> > > MFH: 2016Q2 > > > > -POPT_PORT_LIB_DEPENDS= libpopt.so:devel/popt > > -POPT_PORT_CPPFLAGS= -I${LOCALBASE}/include > > -POPT_PORT_LDFLAGS= -L${LOCALBASE}/lib > > -POPT_CONFIGURE_WITH= included-popt > > +POPT_PORT_LIB_DEPENDS_OFF= libpopt.so:devel/popt > > +POPT_PORT_CPPFLAGS_OFF= -I${LOCALBASE}/include > > +POPT_PORT_LDFLAGS_OFF= -L${LOCALBASE}/lib > > + > > +POPT_PORT_CONFIGURE_WITH= included-popt > > Wait, now you've made it backwards. > > Now: > "Use popt from devel/popt" > ON = use bundled popt > OFF = use popt from devel/popt > > Those need to be switched! Of course you're right. Emanuel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160603092125.2476cdcae34209c83d62ae91>