Date: Wed, 18 Feb 2026 18:53:28 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org> Subject: Re: git: 354cc5e14263 - stable/14 - Merge commit bfb276e55c76 from upstream OpenZFS (by Jessica Clarke) Message-ID: <549554B7-B7D1-4149-9EC5-1B4AA53100F4@freebsd.org> In-Reply-To: <69960995.410bf.1000f305@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 18 Feb 2026, at 18:48, Jessica Clarke <jrtc27@FreeBSD.org> wrote: > The branch stable/14 has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=354cc5e142634afbc967ede56572b939fbdb5d38 > > commit 354cc5e142634afbc967ede56572b939fbdb5d38 > Author: Jessica Clarke <jrtc27@FreeBSD.org> > AuthorDate: 2026-02-18 18:45:26 +0000 > Commit: Jessica Clarke <jrtc27@FreeBSD.org> > CommitDate: 2026-02-18 18:48:46 +0000 > > Merge commit bfb276e55c76 from upstream OpenZFS (by Jessica Clarke) > > Once upon a time, 32-bit PowerPC did indeed have a 32-bit time_t, but > FreeBSD 12.0 switched to a 64-bit time_t for PowerPC as an ABI break, > which predates the addition of FreeBSD support to OpenZFS. Moreover, > 64-bit PowerPC has existed since FreeBSD 9.0, where __powerpc__ is also > defined (alongside __powerpc64__ to disambiguate), which has always had > a 64-bit time_t. This code has therefore always been wrong for all > PowerPC variants. Fix this by limiting the 32-bit case to just i386, > which is the only architecture in FreeBSD to have a 32-bit time_t and > not have broken ABI, due to its special legacy compatibility status. > > Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> > Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> > Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com> > Closes #18217 > Closes #18218 > > Reported by: fuz > MFC after: 1 day > > (cherry picked from commit 45c1e44779e3d365f5e31f75546d48ce34e4ee05) MFCed early at the request of cperciva@ for 14.4. Jessicahome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?549554B7-B7D1-4149-9EC5-1B4AA53100F4>